Skip to content

Conversation

@suv27
Copy link
Contributor

@suv27 suv27 commented Oct 7, 2019

Writing tests for the statistics.py and the methods:

  • rotation_matrix()
  • vcv_cart2local()
  • vcv_local2cart2()
  • error_ellipse()
  • circ_hz_pu()
  • k_val95()

How to Test

  1. Create a virtual env python3 -m venv env
  2. Enter the virtual environment source env/bin/activate
  3. Upgrade pip pip install --upgrade pip
  4. Install coverage -> pip install coverage
  5. Install numpy -> pip install numpy
  6. Run the test -> coverage run geodepy/tests/test_statistics.py
  7. Run the report -> coverage report ../geodepy/geodepy/statistics.py
  8. Run coverage html ../geodepy/geodepy/statistics.py
  9. Open in Browser open htmlcov/index.html

@suv27 suv27 changed the title Issue #82: Unit Tests for statistics.py Issue #82: Unit Tests for statistics.py Oct 7, 2019
Copy link
Collaborator

@harry093 harry093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Physsix27 thanks heaps for coding up these tests. Please have a look at the comments I have made in each of the files

Copy link
Contributor Author

@suv27 suv27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you review this PR

Copy link
Collaborator

@harry093 harry093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Physsix27 I appreciate your work on this. Closes #82

@harry093 harry093 merged commit f9e38bb into GeoscienceAustralia:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants