Skip to content

Conversation

@harry093
Copy link
Collaborator

@harry093 harry093 commented Apr 3, 2020

Added contents of Height_filenames to constants module
Added contents of Normal_Correction to height module
Refactored tests etc.

Added contents of Height_filenames to constants module
Added contents of Normal_Correction to height module
Refactored tests etc.
@harry093 harry093 requested a review from BatchelorJ April 3, 2020 00:26
Copy link
Contributor

@BatchelorJ BatchelorJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! I noticed you snuck in a new GNSS module too ;). Getting some tests for that would be good, along with some general tidying up of comments and headers in the heights module to match the other modules. Happy to merge at this point though.

@harry093
Copy link
Collaborator Author

harry093 commented Apr 3, 2020

@BatchelorJ yeah didn't want that included but realised too late. Thanks for reviewing

@harry093 harry093 merged commit c7cb931 into master Apr 3, 2020
@harry093 harry093 deleted the tidy-up-height branch April 3, 2020 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants