Closed
Conversation
|
I've reconsidered my original decision and decided to unconditionally set the timezone to UTC in the main file. The reasons for this being not only the (annoying) warning, but also that the indexer will start incorrectly picking up files as being modified if the user decides to change his timezone in the I've credited you for this change in the changelog and it will be available in 0.7.0. Thanks! |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be nice if a default PHP timezone is set, so no editing of ini-files is necessary to get this package up and running.
In issue #57 it was decided to not set a default timezone, however PHP sets the default timezone to
UTCanyhow when if it throws the error.So I don't see an issue why
UTCcould not be set as default timezone (as long as no timezone is set).