Ensure chat works with default types

[tbarbugli]

Make sure to use the "messaging" channel type and that the open_demo sets up the channel in such way that both agent and user can access it

This should resolve the problem reported by #97

Summary by CodeRabbit

• New Features
  • Demo experience improved: automatically creates the demo channel, ensures agent and user are added as members, and includes the channel type in the demo URL. Timestamps standardized to UTC.
• Refactor
  • Streamlined track handling and connection flow with clearer, more structured logging; no functional changes.
• Style
  • Consistent multiline formatting and message clarity across logs.
• Chores
  • Removed an outdated demo entry point to simplify the interface.

[coderabbitai]

Walkthrough

The PR updates stream_edge_transport.py with expanded imports, logging reformatting, and readability tweaks. It modifies open_demo to create a channel if needed and ensure members are added, includes channel_type in demo URL params, and removes open_pronto. Track publish/remove handlers and join/audio handlers are reformatted without behavioral changes.

Changes

Cohort / File(s)	Summary of changes
Imports and types plugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.py	Added datetime import; imported ChannelMember; expanded Participant/TrackType imports; no behavior change.
Track publish/remove handling .../stream_edge_transport.py	Reformatted _on_track_published and _on_track_removed: multiline logs, explicit event construction, expanded None/attribute checks; logic preserved.
Join and audio handlers .../stream_edge_transport.py	Reflowed on_track/on_audio_received logs; clarified await context entry; multiline AudioStreamTrack construction; no functional changes.
Demo channel management .../stream_edge_transport.py	open_demo now ensures channel exists, adds agent/human members if missing, includes channel_type in URL params, uses datetime.UTC; refined URL string formatting.
Removed functionality .../stream_edge_transport.py	Removed open_pronto method and references.
Logging/style cleanups .../stream_edge_transport.py	Consistent multiline logging/messages; reflowed long lines; no behavior change.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Agent as Agent (StreamEdge)
  participant Stream as GetStream Channel API

  User->>Agent: open_demo()
  rect rgb(240,245,255)
    note right of Agent: Ensure demo channel and membership
    Agent->>Stream: Create or get channel
    Stream-->>Agent: Channel reference
    Agent->>Stream: Add/ensure members (agent, human)
    Stream-->>Agent: Membership confirmed
  end
  Agent-->>User: Return demo URL (includes channel_type)

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Fix default channel type #96 — Also modifies demo/channel creation logic and handling of channel_type in the same module.

Poem

The channel opens like a blue mouth of noon,
Names pinned to its lip, agent and human, twins.
Old paths fall silent—pronto is a husk—
While logs unspool, neat stitches in the dusk.
We enter, counted, bright with typed intent,
A small republic of tracks, made evident.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 38.46% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title concisely describes the main change of enabling chat with default types by selecting the messaging channel type and updating the demo setup. It directly reflects the key objective without extraneous detail. It is clear and specific enough that a teammate scanning history understands the primary intent.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ensure-chat

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

plugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.py (2)

288-290: Address the TODO comment about the manual context manager entry.

Manually calling __aenter__() on a context manager is unusual and error-prone, as it bypasses the normal async with pattern and requires manual cleanup. The TODO comment acknowledges this is a "weird API."

Consider refactoring to either:

1. Use async with connection: if the connection supports it
2. Expose a proper connect() method from the ConnectionManager class

Do you want me to investigate the ConnectionManager API or open an issue to track this technical debt?

---

343-381: Validate redundant member addition and centralize ChannelMember creation

• Confirm whether get_or_create(members=[…]) reliably adds members and drop the extra channel.update if safe.
• Extract the repeated ChannelMember(...) instantiation into a private helper to eliminate duplication and consolidate the TODO.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 89d346b and 3860c43.

📒 Files selected for processing (1)

• plugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.py (11 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.py

📄 CodeRabbit inference engine (.cursor/rules/python.mdc)

**/*.py: Never adjust sys.path (e.g., sys.path.append/insert/assignment)
Docstrings must follow the Google style guide

Files:

• plugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.py

🧬 Code graph analysis (1)

plugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.py (5)

agents-core/vision_agents/core/edge/types.py (2)

• Participant (22-24)
• PcmData (37-183)

agents-core/vision_agents/core/edge/sfu_events.py (17)

• Participant (204-244)
• user_id (446-450)
• user_id (761-765)
• user_id (798-802)
• user_id (1047-1051)
• user_id (1852-1856)
• user_id (1890-1894)
• track_type (528-532)
• track_type (1054-1058)
• track_type (2023-2027)
• participant (1322-1327)
• participant (1360-1365)
• participant (1421-1426)
• participant (1859-1864)
• participant (1904-1909)
• ParticipantLeftEvent (1347-1382)
• TrackUnpublishedEvent (1884-1926)

agents-core/vision_agents/core/edge/edge_transport.py (1)

• EdgeTransport (18-59)

agents-core/vision_agents/core/events/manager.py (2)

• send (406-449)
• silent (397-404)

agents-core/vision_agents/core/edge/events.py (3)

• TrackAddedEvent (17-22)
• TrackRemovedEvent (26-31)
• AudioReceivedEvent (9-13)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: unit / Ruff & mypy
• GitHub Check: unit / Ruff & mypy

🔇 Additional comments (13)

plugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.py (13)

12-12: LGTM!

ChannelMember import is correctly added and used in the open_demo method.

---

17-20: LGTM!

The expanded imports for Participant and TrackType from the protobuf models are correctly structured and used throughout the file.

---

80-92: LGTM!

The multiline formatting of TrackType conditionals improves readability without changing behavior.

---

116-118: LGTM!

Multiline logging format improves readability.

---

130-141: LGTM!

The reformatted loop for matching pending tracks maintains correct logic while improving readability. The use of list() wrapper prevents modification-during-iteration issues.

---

152-165: LGTM!

The multiline construction of TrackAddedEvent improves readability and explicitly shows all fields being passed.

---

175-177: LGTM!

Using union type syntax (|) for the method signature is more modern and readable than separate overloads or Union[].

---

212-220: LGTM!

The multiline construction of TrackRemovedEvent improves readability and matches the style used for TrackAddedEvent.

---

271-273: LGTM!

Multiline logging format improves readability.

---

279-286: LGTM!

The multiline construction of AudioReceivedEvent improves readability.

---

297-299: LGTM!

Multiline construction of AudioStreamTrack improves readability.

---

304-306: LGTM!

Multiline method signature formatting improves readability.

---

398-398: LGTM!

Including channel_type in the demo URL parameters ensures the correct channel type is used, which aligns with the PR objective of ensuring chat works with default types.

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify Python version compatibility for datetime.UTC.

The datetime import is added but datetime.UTC is used later in the file (lines 355, 358, 373, 376), which requires Python 3.11+. If the project supports older Python versions, this will cause an AttributeError.

---

🏁 Script executed:

#!/bin/bash
# Check Python version requirements in the project

# Check pyproject.toml, setup.py, or requirements files for Python version constraints
fd -t f 'pyproject.toml|setup.py|setup.cfg|requirements.*txt' --exec cat {} \; | rg -i 'python.*version|requires-python|python_requires'

# Check for other usages of datetime.UTC in the codebase
rg -n 'datetime\.UTC' --type py

Length of output: 1520

---

Replace datetime.UTC with timezone.utc for Python 3.10 compatibility
datetime.UTC is only available in Python 3.11+ (used at lines 355, 358, 373, 376); replace with datetime.timezone.utc to maintain support for requires-python >=3.10.

🤖 Prompt for AI Agents

In plugins/getstream/vision_agents/plugins/getstream/stream_edge_transport.py
around lines 355, 358, 373 and 376, replace usages of datetime.UTC (which is
only in Python 3.11+) with datetime.timezone.utc to maintain Python 3.10
compatibility; ensure the module import remains "import datetime" (so
datetime.timezone is available) and update those four occurrences to
datetime.timezone.utc.