Remove device-width API and mobile-press class from message component #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlaz
requested review from
MartinCupela,
arnautov-anton,
petyosi and
szuperaz
This was referenced Jun 24, 2022
szuperaz
approved these changes
Jun 24, 2022
…onent BREAKING CHANGE: this commit removes the `device-width` API from the SDK and changes the way how message actions render. mobile-press: This class was toggled whenever a user pressed on a message in the message list. The primary goal of this class is to make the message actions visible on devices that don't support "hover" events (mobile devices). We found a better solution by offloading this behavior to the browser and utilizing `:focus` and `:focus-within` CSS pseudo-selectors. device-width: This module did hold the responsive UI breakpoints. We realized they aren't always in line with the rest of our stylesheets. We remove this module from the API since we believe breakpoints should be defined in the integration projects.
oliverlaz
force-pushed
the
fix/remove-mobile-press
branch
from
235364f to
25291df
Compare
petyosi
approved these changes
Jun 27, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
# [4.0.0-theming-v2.1](v3.5.3...v4.0.0-theming-v2.1) (2022-07-11) ### Bug Fixes * Chat layout ([b8ef6a2](b8ef6a2)) * Context menu and tooltip positioning (theme-v1 and v2) ([d7975fe](d7975fe)) * Design enhancements ([1ec60b7](1ec60b7)) * Design enhancements and fixes ([76a0e67](76a0e67)) * Don't apply unread state to active channel ([6bdef4a](6bdef4a)) * Fix emoji picker in sample app ([27ea7e7](27ea7e7)) * Long quoted message in message input ([0708062](0708062)) * Migrate to ngx-popperjs ([a30925f](a30925f)) * Remove React message notifications class from Angular jump to latest button ([42c4f65](42c4f65)) * Remove React specific CSS class from jump to latest button ([c80fc03](c80fc03)) * Remove device-width API and mobile-press class from message component (#322) ([20b2a96](20b2a96)), closes [#322](#322) ### Features * Add empty channel list indicator to theme-v2 (theme-v1 updated) ([dc757bc](dc757bc)) * Add unread badge for themev1 and v2 ([7728f0b](7728f0b)) * Additional error notifications ([8d37d19](8d37d19)) * Apply theme-v2 for channel and channel header [#284](#284) ([53f746c](53f746c)) * Apply theme-v2 to channel list and preview [#285](#285) ([ecb6acb](ecb6acb)) * Apply theme-v2 to message component [#282](#282) ([19fcdaa](19fcdaa)) * Apply theme-v2 to message input [#283](#283) ([d321798](d321798)) * Apply theme-v2 to typing indicator [#281](#281) ([a61b43d](a61b43d)) * apply themev2 for channel list ([2f45805](2f45805)) * Increase hit area of message actions buttons ([96a48d8](96a48d8)) * Message input theme-v2 missing features [#283](#283) ([d9b0106](d9b0106)) * Message reactions [#279](#279) ([898797d](898797d)) * Modal component theme-v2 [#278](#278) ([413fdb0](413fdb0)) * Notification theme-v2 [#277](#277) ([a826a11](a826a11)) * Remove unnecessary slot selectors from thread ([2fdb9a3](2fdb9a3)) ### BREAKING CHANGES * this commit removes the `device-width` API from the SDK and changes the way how message actions render. mobile-press: This class was toggled whenever a user pressed on a message in the message list. The primary goal of this class is to make the message actions visible on devices that don't support "hover" events (mobile devices). We found a better solution by offloading this behavior to the browser and utilizing `:focus` and `:focus-within` CSS pseudo-selectors. device-width: This module did hold the responsive UI breakpoints. We realized they aren't always in line with the rest of our stylesheets. We remove this module from the API since we believe breakpoints should be defined in the integration projects.
Contributor
|
🎉 This PR is included in version 4.0.0-theming-v2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
# [4.0.0](v3.8.2...v4.0.0) (2022-08-24) ### Bug Fixes * Add Angular specific selectors to message input ([b5e150f](b5e150f)) * Chat layout ([b8ef6a2](b8ef6a2)) * Context menu and tooltip positioning (theme-v1 and v2) ([d7975fe](d7975fe)) * Design enhancements ([1ec60b7](1ec60b7)) * Design enhancements and fixes ([76a0e67](76a0e67)) * Don't apply unread state to active channel ([6bdef4a](6bdef4a)) * Fix emoji picker in sample app ([27ea7e7](27ea7e7)) * Long quoted message in message input ([0708062](0708062)) * Mention autocomplete in theme-v1 ([f82db39](f82db39)) * Migrate to ngx-popperjs ([a30925f](a30925f)) * Remove React message notifications class from Angular jump to latest button ([42c4f65](42c4f65)) * Remove React specific CSS class from jump to latest button ([c80fc03](c80fc03)) * Remove unnecessary class from notification list ([b556ddf](b556ddf)) * Remove device-width API and mobile-press class from message component (#322) ([20b2a96](20b2a96)), closes [#322](#322) ### Features * Add CSS class to SVG images ([a085741](a085741)) * Add empty channel list indicator to theme-v2 (theme-v1 updated) ([dc757bc](dc757bc)) * Add message mention style to theme-v2 ([896ee0b](896ee0b)) * Add unread badge for themev1 and v2 ([7728f0b](7728f0b)) * Additional error notifications ([8d37d19](8d37d19)) * Apply theme-v2 for channel and channel header [#284](#284) ([53f746c](53f746c)) * Apply theme-v2 to channel list and preview [#285](#285) ([ecb6acb](ecb6acb)) * Apply theme-v2 to message component [#282](#282) ([19fcdaa](19fcdaa)) * Apply theme-v2 to message input [#283](#283) ([d321798](d321798)) * Apply theme-v2 to typing indicator [#281](#281) ([a61b43d](a61b43d)) * apply themev2 for channel list ([2f45805](2f45805)) * Empty commit to trigger a semantic release ([a64638d](a64638d)) * Increase hit area of message actions buttons ([96a48d8](96a48d8)) * Message input theme-v2 missing features [#283](#283) ([d9b0106](d9b0106)) * Message reactions [#279](#279) ([898797d](898797d)) * Modal component theme-v2 [#278](#278) ([413fdb0](413fdb0)) * Notification theme-v2 [#277](#277) ([a826a11](a826a11)) * Remove unnecessary slot selectors from thread ([2fdb9a3](2fdb9a3)) * stream-chat-css updated ([2dbbb71](2dbbb71)) * Update stream-chat-css ([262ff78](262ff78)) * Update stream-chat-css ([12d4a65](12d4a65)) * Video sizing update ([9ea2386](9ea2386)) ### BREAKING CHANGES * Some changes were introduced to the CSS so you might have to update your custom CSS code * this commit removes the `device-width` API from the SDK and changes the way how message actions render. mobile-press: This class was toggled whenever a user pressed on a message in the message list. The primary goal of this class is to make the message actions visible on devices that don't support "hover" events (mobile devices). We found a better solution by offloading this behavior to the browser and utilizing `:focus` and `:focus-within` CSS pseudo-selectors. device-width: This module did hold the responsive UI breakpoints. We realized they aren't always in line with the rest of our stylesheets. We remove this module from the API since we believe breakpoints should be defined in the integration projects.
Contributor
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal:
BREAKING CHANGE: this commit removes the
device-widthAPI from the SDK and changes the way how message actions render.Notes:
.mobile-press:This class was toggled whenever a user pressed on a message in the message list. The primary goal of this class is to make the message actions visible on devices that don't support "hover" events (mobile devices).
We found a better solution by offloading this behavior to the browser and utilizing
:focusand:focus-withinCSS pseudo-selectors.device-width:
This module did hold the responsive UI breakpoints. We realized they aren't always in line with the rest of our stylesheets. We remove this module from the API since we believe breakpoints should be defined in the integration projects.
Related PRs: