feat: add options to truncate #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterdeme
requested review from
driver-devel,
ferhatelmas and
miagilepner
as code owners
peterdeme
force-pushed
the
truncate-with-options
branch
2 times, most recently
from
63255a0 to
e536bcb
Compare
Contributor
|
We're moving public class ChannelTruncateRequest into another namespace, so it's breaking change. We could make builder from this object. |
Contributor
|
@peterdeme feel free to ignore breaking change since this not widely used i think we can proceed with that |
Contributor
|
I bumped rate limits of the app 20x |
peterdeme
force-pushed
the
truncate-with-options
branch
from
e536bcb to
abaa75f
Compare
peterdeme
force-pushed
the
truncate-with-options
branch
from
abaa75f to
74bcdff
Compare
This was referenced Jan 18, 2022
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added truncate options