feat: add missing requests #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peterdeme
commented
Jan 11, 2022
peterdeme
commented
- Full feature parity for Java
peterdeme
requested review from
driver-devel,
ferhatelmas and
miagilepner
as code owners
| @Nullable @Query("type") String channelType, | ||
| @Nullable @Query("id") String channelId); | ||
| @Nullable @Query("id") String channelId, | ||
| @Nullable @Query("shadow") Boolean shadow); |
Contributor
There was a problem hiding this comment.
Seems like this param doesn't have any effect. It removes 2 types of bans. @ferhatelmas
Contributor
Author
There was a problem hiding this comment.
interesting. I couldn't find it in the REST docs, but Python/Ruby etc has it
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
I see go sdk has it too 🤔. Alright, let's keep it for consistency
Contributor
Author
There was a problem hiding this comment.
and the tests succeed as well, so.. 🤔
driver-devel
approved these changes
Jan 12, 2022
This was referenced Jan 18, 2022
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.