feat: add support for show_deleted_message in getMessage #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
stream_chat/client.py
Outdated
| return self.delete(f"messages/{message_id}", options) | ||
|
|
||
| def get_message(self, message_id: str) -> StreamResponse: | ||
| def get_message( |
Contributor
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Function is missing a type annotation for one or more arguments [no-untyped-def]
totalimmersion
requested changes
Mar 5, 2024
guerinoni
force-pushed
the
show_deleted_message
branch
from
f5c1da6 to
8bfae05
Compare
totalimmersion
requested changes
Mar 5, 2024
Contributor
totalimmersion
left a comment
totalimmersion
left a comment
There was a problem hiding this comment.
I'm also missing a few tests
guerinoni
force-pushed
the
show_deleted_message
branch
from
8bfae05 to
de795c6
Compare
guerinoni
force-pushed
the
show_deleted_message
branch
from
de795c6 to
4cefecf
Compare
totalimmersion
approved these changes
Mar 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
CLA
Description of the pull request