Skip to content

Conversation

@nijeesh-stream
Copy link
Contributor

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Changes

  1. Fixed query_reminders API call to use filter parameter instead of filter_conditions (both sync and async clients)
  2. Enhanced test assertions to verify filter results actually match criteria
  3. Added test cases for exact message_id filter and channel_cid filter verification

Why

  • The API expects the parameter name filter, not filter_conditions
  • Previous tests only checked API success, not that filters actually worked
  • This ensures both code correctness and test quality

Testing

  • ✅ All sync tests pass with strong filter verification
  • ✅ All async tests pass with strong filter verification
  • ✅ Tests now verify returned data matches filter criteria
  • ✅ Manually verified with production staging credentials

@nijeesh-stream nijeesh-stream enabled auto-merge (squash) November 19, 2025 17:49
"""
params = options.copy()
params["filter_conditions"] = filter_conditions or {}
params["filter"] = filter_conditions or {}
Copy link

@10printhello 10printhello Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note: if you've renamed the param to filter here, should the func arg (filter_conditions) change also as the other args match the params (user_id & user_id etc)?

Appreciate this might be a breaking change which is why you haven't. Thought worth mentioning for consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, i didn't want to change it as its a breaking change

@nijeesh-stream nijeesh-stream merged commit b80c3d9 into master Nov 20, 2025
9 of 11 checks passed
@nijeesh-stream nijeesh-stream deleted the fix_reminders_query branch November 20, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants