Commit 89076d5
authored
fix: stop replaying audio on expo when seeing to 0 (#3603)
## 🎯 Goal
This PR removes a relatively archaic functionality we've had for voice
recordings where seeking to 0 would begin audio replay. This is neither
according to our new design system, nor does it make specific sense.
In fact, it would break the state completely as `replayAsync` does not
go through the `requestPlay` lifecycle of our `audio-player` pool,
meaning we would not be getting any state updates (and have audio
playing). Integrators anyway have access to the pool if they wish to
control this themselves.
## 🛠 Implementation details
<!-- Provide a description of the implementation -->
## 🎨 UI Changes
<!-- Add relevant screenshots -->
<details>
<summary>iOS</summary>
<table>
<thead>
<tr>
<td>Before</td>
<td>After</td>
</tr>
</thead>
<tbody>
<tr>
<td>
<!--<img src="" /> -->
</td>
<td>
<!--<img src="" /> -->
</td>
</tr>
</tbody>
</table>
</details>
<details>
<summary>Android</summary>
<table>
<thead>
<tr>
<td>Before</td>
<td>After</td>
</tr>
</thead>
<tbody>
<tr>
<td>
<!--<img src="" /> -->
</td>
<td>
<!--<img src="" /> -->
</td>
</tr>
</tbody>
</table>
</details>
## 🧪 Testing
<!-- Explain how this change can be tested (or why it can't be tested)
-->
## ☑️ Checklist
- [ ] I have signed the [Stream
CLA](https://docs.google.com/forms/d/e/1FAIpQLScFKsKkAJI7mhCr7K9rEIOpqIDThrWxuvxnwUq2XkHyG154vQ/viewform)
(required)
- [ ] PR targets the `develop` branch
- [ ] Documentation is updated
- [ ] New code is tested in main example apps, including all possible
scenarios
- [ ] SampleApp iOS and Android
- [ ] Expo iOS and Android1 parent bc8eb82 commit 89076d5
2 files changed
Lines changed: 7 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6073 | 6073 | | |
6074 | 6074 | | |
6075 | 6075 | | |
6076 | | - | |
6077 | | - | |
6078 | | - | |
6079 | | - | |
| 6076 | + | |
| 6077 | + | |
| 6078 | + | |
| 6079 | + | |
6080 | 6080 | | |
6081 | 6081 | | |
6082 | 6082 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
425 | 425 | | |
426 | 426 | | |
427 | 427 | | |
428 | | - | |
429 | | - | |
430 | | - | |
431 | | - | |
432 | | - | |
| 428 | + | |
| 429 | + | |
433 | 430 | | |
434 | | - | |
435 | | - | |
436 | | - | |
437 | | - | |
438 | | - | |
| 431 | + | |
439 | 432 | | |
440 | 433 | | |
441 | 434 | | |
| |||
0 commit comments