feat: add ability to handle bounced message#2415
Merged
Merged
Conversation
santhoshvai
reviewed
Feb 5, 2024
santhoshvai
reviewed
Feb 5, 2024
santhoshvai
reviewed
Feb 5, 2024
santhoshvai
reviewed
Feb 5, 2024
santhoshvai
reviewed
Feb 5, 2024
santhoshvai
approved these changes
Feb 6, 2024
Contributor
|
🎉 This PR is included in version 5.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
The goal of the PR is to introduce the ability to handle bounced messages.
🛠 Implementation details
Product-wise, if a bounced message is sent in a channel, it should show an error icon, which, on long press/press, should open a model with three capabilities: Send Anyway, Edit message, and Delete message.
A new component that shows an alert named
MessageBounceis introduced. It's a type component since users can also feel free to make their own components if they want, not limiting themselves to the Alert we have by default.Note: The edit message is different for bounced messages. It should resend a new message with the new text changes in the edit.
Note: The editing state variable was
MessageType<StreamChatGeneric> | booleanbefore; this has been changed toMessageType<StreamChatGeneric> | undefinednow, improving readability.🎨 UI Changes
Screen.Recording.2024-02-05.at.5.16.52.PM.mov
🧪 Testing
☑️ Checklist
developbranch