Skip to content

feat: track attachment uploads outside of message composer - in progress#3527

Merged
isekovanic merged 3 commits intodevelopfrom
track-file-uploads-outside-message-composer
Apr 24, 2026
Merged

feat: track attachment uploads outside of message composer - in progress#3527
isekovanic merged 3 commits intodevelopfrom
track-file-uploads-outside-message-composer

Conversation

@szuperaz
Copy link
Copy Markdown
Contributor

@szuperaz szuperaz commented Apr 2, 2026

🎯 Goal

Depends on: GetStream/stream-chat-js#1715

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@szuperaz szuperaz force-pushed the track-file-uploads-outside-message-composer branch from b5486a4 to 373dac3 Compare April 20, 2026 09:07
szuperaz added a commit to GetStream/stream-chat-js that referenced this pull request Apr 23, 2026
…ntManager (#1715)

## CLA

- [ ] I have signed the [Stream
CLA](https://docs.google.com/forms/d/e/1FAIpQLScFKsKkAJI7mhCr7K9rEIOpqIDThrWxuvxnwUq2XkHyG154vQ/viewform)
(required).
- [ ] Code changes are tested

## Description of the changes, What, Why and How?

RN PR for reference:
GetStream/stream-chat-react-native#3527

React Native allows hitting the send button before attachment uploads
are completed. This means they need a way to track attachment upload
status outside of `AttachmentManager`.

To solve this we have an `UploadManager` (can be accessed via
`client.uploadManager`) that uses the `AttachmentManager` of a given
channel to do attachment upload, and has a state to track
`uploadProgress` for attachments.

Attachments are tracked by `id` in `UploadManager`.

Long-term solution: we talked with @isekovanic that `messageComposer`
should have support for this feature, but that is a bigger task, not the
scope of this PR.

## Changelog

-
# Conflicts:
#	package/src/components/Attachment/__tests__/Attachment.test.tsx
#	package/src/components/Attachment/__tests__/Giphy.test.tsx
@isekovanic isekovanic marked this pull request as ready for review April 24, 2026 12:25
@isekovanic isekovanic self-requested a review April 24, 2026 12:26
@isekovanic isekovanic merged commit fcbdae0 into develop Apr 24, 2026
1 of 5 checks passed
@isekovanic isekovanic deleted the track-file-uploads-outside-message-composer branch April 24, 2026 12:27
@github-actions github-actions Bot mentioned this pull request Apr 24, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants