fix: flash list scroll to behaviour#3602
Merged
Merged
Conversation
isekovanic
commented
May 19, 2026
Contributor
SDK Size
|
szuperaz
approved these changes
May 19, 2026
6 tasks
isekovanic
added a commit
that referenced
this pull request
May 19, 2026
## π― Goal This is a backport of [this PR](#3602) towards V8. All details are in its description. ## π Implementation details <!-- Provide a description of the implementation --> ## π¨ UI Changes <!-- Add relevant screenshots --> <details> <summary>iOS</summary> <table> <thead> <tr> <td>Before</td> <td>After</td> </tr> </thead> <tbody> <tr> <td> <!--<img src="" /> --> </td> <td> <!--<img src="" /> --> </td> </tr> </tbody> </table> </details> <details> <summary>Android</summary> <table> <thead> <tr> <td>Before</td> <td>After</td> </tr> </thead> <tbody> <tr> <td> <!--<img src="" /> --> </td> <td> <!--<img src="" /> --> </td> </tr> </tbody> </table> </details> ## π§ͺ Testing <!-- Explain how this change can be tested (or why it can't be tested) --> ## βοΈ Checklist - [ ] I have signed the [Stream CLA](https://docs.google.com/forms/d/e/1FAIpQLScFKsKkAJI7mhCr7K9rEIOpqIDThrWxuvxnwUq2XkHyG154vQ/viewform) (required) - [ ] PR targets the `develop` branch - [ ] Documentation is updated - [ ] New code is tested in main example apps, including all possible scenarios - [ ] SampleApp iOS and Android - [ ] Expo iOS and Android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π― Goal
This PR addresses 2 issues with
MessageFlashListwhich have madescrollTobehaviour unreliable.Even though these 2 issues are seemingly similar, their underlying causes are completely different.
Quoted message scroll to
This particular issue happens specifically when we've loaded the messages into memory that we want to scroll to (so loading a completely different
messageSetis working fine). The offender here is MVCP and scrolling to bottom in particular. I'm pretty certain that there's an upstream bug here, however I did not have a chance to debug it more thoroughly and find the actual root cause. Roughly what goes on is the following:I actually had a patch in
FlashListwhich allows us to clear all pending MVCP scrolls and also suspend MVCP from doing anything and it worked like a charm (like an imperative API).However for now, this will have to do. At the very least, even when the issue happens it should reconcile shortly after and fix its positioning.
Initial scroll to first unread
This issue on the other hand is completely unrelated to MVCP. It's actually related to our automatic scrolling mechanism, which happens on mount and then also whenever
autoscrollToRecentactually changes. Namely, if we look intoFlashList's implementation we can see thatscrollToEndis actually ultimately wrapped within asetTimeout, likely to try to delay it natively on the JS runtime for timing purposes. However, this also means that if a state update happens really quickly (for exampletargetedMessageupdating) we'll end up making the 2 scrolls race.scrollToEndtypically wins because it's invoked later and also because it invokes the underlying scroll view's ref rather than some abstraction.We need this custom handling because
initialScrollIndexforFlashListis very often not correct at all (and off by some number of offset). This is especially true whenever we scroll between 2 message sets and virtually load new data. I've yet to find why this is but maybe some day.To prevent this, we expose a new API on the
Channellevel that allows us to anticipate when we're about to scroll to a targeted message, bypassing thescrollToEndentirely in favor of having a pending scroll.These fixes will be ported back to V8 as well.
π Implementation details
π¨ UI Changes
iOS
Android
π§ͺ Testing
βοΈ Checklist
developbranch