CRNS-116: Channel preview tests and hooks #251

vishalnarkhede · 2020-07-27T11:59:29Z

Submit a pull request

CLA

I have signed the Stream CLA (required).
The code changes follow best practices
Code changes are tested (add some information if not applicable)

Description of the pull request

Config setup for jest and native-testing-library
Adding tests for ChannelPreview and ChannelPreviewMessenger
Converting ChannelPreview and ChannelPreviewMessenger to hooks

…e into vishal/channel-preview-messenger-tests

…t-native into vishal/channel-preview-messenger-tests

virdesai

I'd like to say we should try to alphabetize things for best practice like lists where order doesn't matter, and objects based on key name or functions based on name. make it easier to search within the code if it's following some natural mental flow

src/components/ChannelPreview/hooks/useLatestMessagePreview.js

src/components/ChannelPreview/hooks/useChannelPreviewDisplayName.js

src/components/ChannelPreview/hooks/useChannelPreviewDisplayAvatar.js

DanC5 · 2020-07-28T14:50:31Z

package.json

    "prettier": "^1.16.4",
    "react": "^16.5.0",
    "react-dom": "^16.8.6",
+    "react-native": "0.61.5",


is there a reason why we're a couple versions behind on RN?

@DanC5 Yeah, I can't seem to remember exactly but it was breaking for 0.62 and 0.63. But give it a shot!!

src/components/ChannelPreview/ChannelPreview.js

virdesai · 2020-07-28T13:55:55Z

src/components/ChannelPreview/ChannelPreview.js

+    return () => {
+      channel.off('message.new', handleNewMessageEvent);
    };
+  });


do you want these to setup just on mount/unmount?

Suggested change

});

}, []);

tested this and the listener won't fire on each new message if we only call on mount. we have an issue tho where when you send a message in a Channel and then nav back to the ChannelList, the ChannelPreview still holds the original value and not the most recent message, looking into it now

Ahh shit ... stupid mistake on my end!!

@vishalnarkhede i fixed it, all good!

the useLatestMessagePreview useEffect needed to be triggered on lastMessage, not channel

virdesai · 2020-07-28T13:56:11Z

src/components/ChannelPreview/ChannelPreview.js

+    return () => {
+      channel.off('message.read', handleReadEvent);
+    };
+  });


do you want these to setup just on mount/unmount?

Suggested change

});

}, []);

virdesai · 2020-07-28T14:31:07Z

src/components/ChannelPreview/ChannelPreview.js

+
+ChannelPreview.propTypes = {
+  channel: PropTypes.object.isRequired,
+  client: PropTypes.object.isRequired,


this is no longer a required prop as we're pulling it from ChatContext, right?

true, and we're going to axe all these prop types anyways shortly with TS

src/components/ChannelPreview/ChannelPreviewMessenger.js

src/components/ChannelPreview/__tests__/ChannelPreview.test.js

src/components/ChannelPreview/__tests__/ChannelPreviewMessenger.test.js

…me.js Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

…atar.js Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

…r.test.js Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

…etStream/stream-chat-react-native into vishal/channel-preview-messenger-tests

vishalnarkhede added 4 commits July 22, 2020 15:06

Tests setup

833ed47

Merge branch 'master' of github.com:GetStream/stream-chat-react-nativ…

bd502b0

…e into vishal/channel-preview-messenger-tests

Merge branch 'vishal/RN-2.0' of github.com:GetStream/stream-chat-reac…

47bea70

…t-native into vishal/channel-preview-messenger-tests

Cleanup

a3e5a5a

vishalnarkhede force-pushed the vishal/channel-preview-messenger-tests branch from 71b93de to eab5de0 Compare July 28, 2020 12:31

vishalnarkhede marked this pull request as ready for review July 28, 2020 12:33

vishalnarkhede changed the title ~~Vishal/channel preview messenger tests~~ CRNS-116: Vishal/channel preview messenger tests Jul 28, 2020

vishalnarkhede force-pushed the vishal/channel-preview-messenger-tests branch from eab5de0 to 9001c9d Compare July 28, 2020 12:40

vishalnarkhede requested review from DanC5, jaapbakker88, nhannah and vini-btc July 28, 2020 13:04

Adding hooks to ChannelPreviewMessenger and ChannelPreview

8f80d79

vishalnarkhede force-pushed the vishal/channel-preview-messenger-tests branch from 9001c9d to 8f80d79 Compare July 28, 2020 13:08

vishalnarkhede changed the title ~~CRNS-116: Vishal/channel preview messenger tests~~ CRNS-116: Channel preview tests and hooks Jul 28, 2020

virdesai reviewed Jul 28, 2020

View reviewed changes

DanC5 reviewed Jul 28, 2020

View reviewed changes

virdesai reviewed Jul 28, 2020

View reviewed changes

Dan Carbonell and others added 12 commits July 28, 2020 09:44

memoize ChannelPreview component

064d08b

Update src/components/ChannelPreview/hooks/useChannelPreviewDisplayNa…

8363ecb

…me.js Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

Update src/components/ChannelPreview/hooks/useChannelPreviewDisplayNa…

078b5fa

…me.js Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

Update src/components/ChannelPreview/hooks/useChannelPreviewDisplayAv…

f76c071

…atar.js Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

Update src/components/ChannelPreview/ChannelPreviewMessenger.js

d82db82

Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

Update src/components/ChannelPreview/ChannelPreviewMessenger.js

adad340

Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

Update src/components/ChannelPreview/__tests__/ChannelPreview.test.js

114d934

Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

Update src/components/ChannelPreview/__tests__/ChannelPreview.test.js

e7d2776

Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

Update src/components/ChannelPreview/__tests__/ChannelPreview.test.js

f61cd25

Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

Update src/components/ChannelPreview/__tests__/ChannelPreviewMessenge…

ea7293f

…r.test.js Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

Update src/components/ChannelPreview/__tests__/ChannelPreviewMessenge…

82ed932

…r.test.js Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

Update src/components/ChannelPreview/ChannelPreviewMessenger.js

b65c1c7

Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

DanC5 and others added 13 commits July 28, 2020 10:11

Update src/components/ChannelPreview/ChannelPreviewMessenger.js

000c79b

Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

Update src/components/ChannelPreview/ChannelPreview.js

716b69b

Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

Update src/components/ChannelPreview/ChannelPreviewMessenger.js

9fe7c83

Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

Update src/components/ChannelPreview/__tests__/ChannelPreview.test.js

c408777

Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

Update src/components/ChannelPreview/__tests__/ChannelPreview.test.js

d660779

Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

Update src/components/ChannelPreview/__tests__/ChannelPreview.test.js

3f52e4c

Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

Update src/components/ChannelPreview/__tests__/ChannelPreview.test.js

12b5df6

Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

Update src/components/ChannelPreview/__tests__/ChannelPreview.test.js

ed90646

Co-authored-by: Vir Desai <virdesai@users.noreply.github.com>

Merge branch 'vishal/channel-preview-messenger-tests' of github.com:G…

c621c34

…etStream/stream-chat-react-native into vishal/channel-preview-messenger-tests

PR comments and clean up

87dbf01

fix useLatestMessagePreview hook

896699c

add dependency arrays

ab3f107

add comment re. inner componene usage

444f98a

vishalnarkhede merged commit 4eec2fb into vishal/RN-2.0 Jul 28, 2020

delete-merged-branch bot deleted the vishal/channel-preview-messenger-tests branch July 28, 2020 20:01

CRNS-116: Channel preview tests and hooks #251

CRNS-116: Channel preview tests and hooks #251

Uh oh!

Conversation

vishalnarkhede commented Jul 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Submit a pull request

CLA

Description of the pull request

Uh oh!

virdesai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vishalnarkhede commented Jul 27, 2020 •

edited

Loading