Fixing issues with FileUploadPreview #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Visibility of retry button was quite poor, because of white color on white background. This reload icon has been changes to contrast on white background 2. Cancel button was unaccessible because of overlapping reload icon container.
vishalnarkhede
force-pushed
the
vishal/file-upload-preview-fix
branch
from
8636958 to
8145482
Compare
added 2 commits
September 15, 2020 12:44
…eview and ImageUploadPreview components
Contributor
Author
|
LGTM!! @virdesai can you please add to changelog of 1.3.0:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Submit a pull request
CLA
Description of the pull request
This is how the upload previews look now