Skip to content

Use new metro-dev-helpers instead of copy-pasted metro config on examples #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 21, 2021
Merged

Use new metro-dev-helpers instead of copy-pasted metro config on examples #713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a6136ae
use new metro-dev-helpers instead of copy-pasted metro config
tsirlucas Jun 18, 2021
f475bd4
use exclusionList on samples where metro-config is updated
tsirlucas Jun 18, 2021
7aea3c9
better organization on metro-dev-helpers
tsirlucas Jun 18, 2021
0d8383e
only exclude node_modules from expo-packages on new metro-dev-helpers
tsirlucas Jun 21, 2021
5ac8a0f
include expo package on alternate roots when available
tsirlucas Jun 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ yarn-error.log
.DS_Store
dist/
lib/
# lib/ ignores metro-dev-helpers/lib so:
!metro-dev-helpers/lib
.env*
examples/SampleApp/ios/vendor/
vendor
Expand Down
155 changes: 5 additions & 150 deletions examples/ExpoMessaging/metro.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,164 +1,19 @@
/* eslint-env node */
function resolvePath(...parts) {
const thisPath = PATH.resolve.apply(PATH, parts);
if (!FS.existsSync(thisPath)) return;

return FS.realpathSync(thisPath);
}

function isExternalModule(modulePath) {
return modulePath.substring(0, __dirname.length) !== __dirname;
}

function listDirectories(rootPath, cb) {
FS.readdirSync(rootPath).forEach((fileName) => {
if (fileName.charAt(0) === '.') return;

let fullFileName = PATH.join(rootPath, fileName),
stats = FS.lstatSync(fullFileName),
symbolic = false;

if (stats.isSymbolicLink()) {
fullFileName = resolvePath(fullFileName);
if (!fullFileName) return;

stats = FS.lstatSync(fullFileName);

symbolic = true;
}

if (!stats.isDirectory()) return;

const external = isExternalModule(fullFileName);
cb({ rootPath, symbolic, external, fullFileName, fileName });
});
}

function buildFullModuleMap(
moduleRoot,
mainModuleMap,
externalModuleMap,
_alreadyVisited,
_prefix,
) {
if (!moduleRoot) return;

const alreadyVisited = _alreadyVisited || {},
prefix = _prefix;

if (alreadyVisited && alreadyVisited.hasOwnProperty(moduleRoot)) return;

alreadyVisited[moduleRoot] = true;

listDirectories(moduleRoot, ({ fileName, fullFileName, symbolic, external }) => {
if (symbolic)
return buildFullModuleMap(
resolvePath(fullFileName, 'node_modules'),
mainModuleMap,
externalModuleMap,
alreadyVisited,
);

const moduleMap = external ? externalModuleMap : mainModuleMap,
moduleName = prefix ? PATH.join(prefix, fileName) : fileName;

if (fileName.charAt(0) !== '@') moduleMap[moduleName] = fullFileName;
else
return buildFullModuleMap(
fullFileName,
mainModuleMap,
externalModuleMap,
alreadyVisited,
fileName,
);
});
}

function buildModuleResolutionMap() {
const moduleMap = {},
externalModuleMap = {};

buildFullModuleMap(baseModulePath, moduleMap, externalModuleMap);

// Root project modules take precedence over external modules
return Object.assign({}, externalModuleMap, moduleMap);
}

function findAlternateRoots(moduleRoot = baseModulePath, alternateRoots = [], _alreadyVisited) {
const alreadyVisited = _alreadyVisited || {};
if (alreadyVisited && alreadyVisited.hasOwnProperty(moduleRoot)) return;

alreadyVisited[moduleRoot] = true;

listDirectories(moduleRoot, ({ fullFileName, fileName, external }) => {
if (fileName.charAt(0) !== '@') {
if (external) alternateRoots.push(fullFileName);
} else {
findAlternateRoots(fullFileName, alternateRoots, alreadyVisited);
}
});

return alternateRoots;
}

function getPolyfillHelper() {
let getPolyfills;

// Get default react-native polyfills
try {
getPolyfills = require('react-native/rn-get-polyfills');
} catch (e) {
getPolyfills = () => [];
}

// See if project has custom polyfills, if so, include the PATH to them
try {
const customPolyfills = require.resolve('./polyfills.js');
getPolyfills = (function (originalGetPolyfills) {
return () => originalGetPolyfills().concat(customPolyfills);
})(getPolyfills);
} catch (e) {
//ignore
}

return getPolyfills;
}

const PATH = require('path');
const FS = require('fs'),
blacklist = require('metro-config/src/defaults/blacklist');
const blacklist = require('metro-config/src/defaults/blackList');

const repoDir = PATH.dirname(PATH.dirname(__dirname));
const extractLinkedPackages = require('stream-chat-react-native-core/metro-dev-helpers/extract-linked-packages');

const moduleBlacklist = [
new RegExp(repoDir + '/examples/NativeMessaging/.*'),
new RegExp(repoDir + '/examples/SampleApp/.*'),
new RegExp(repoDir + '/examples/TypeScriptMessaging/.*'),
new RegExp(repoDir + '/native-package/.*'),
new RegExp(repoDir + '/expo-package/node_modules/.*'),
new RegExp(repoDir + '/node_modules/.*'),
],
baseModulePath = resolvePath(__dirname, 'node_modules'),
// watch alternate roots (outside of project root)
alternateRoots = findAlternateRoots(),
// build full module map for proper
// resolution of modules in external roots
extraNodeModules = buildModuleResolutionMap();
const projectRoot = PATH.resolve(__dirname);

if (alternateRoots && alternateRoots.length)
console.log('Found alternate project roots: ', alternateRoots);
const { alternateRoots, extraNodeModules, moduleBlacklist } = extractLinkedPackages(projectRoot);

module.exports = {
resolver: {
blacklistRE: blacklist(moduleBlacklist),
extraNodeModules,
useWatchman: false,
},
watchFolders: [PATH.resolve(__dirname)].concat(alternateRoots),
// transformer: {
// babelTransformerPath: require.resolve('./compiler/transformer'),
// },
serializer: {
getPolyfills: getPolyfillHelper(),
},
watchFolders: [projectRoot].concat(alternateRoots),
};
157 changes: 6 additions & 151 deletions examples/NativeMessaging/metro.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,164 +1,19 @@
/* eslint-env node */
function resolvePath(...parts) {
const thisPath = PATH.resolve.apply(PATH, parts);
if (!FS.existsSync(thisPath)) return;

return FS.realpathSync(thisPath);
}

function isExternalModule(modulePath) {
return modulePath.substring(0, __dirname.length) !== __dirname;
}

function listDirectories(rootPath, cb) {
FS.readdirSync(rootPath).forEach((fileName) => {
if (fileName.charAt(0) === '.') return;

let fullFileName = PATH.join(rootPath, fileName),
stats = FS.lstatSync(fullFileName),
symbolic = false;

if (stats.isSymbolicLink()) {
fullFileName = resolvePath(fullFileName);
if (!fullFileName) return;

stats = FS.lstatSync(fullFileName);

symbolic = true;
}

if (!stats.isDirectory()) return;

const external = isExternalModule(fullFileName);
cb({ rootPath, symbolic, external, fullFileName, fileName });
});
}

function buildFullModuleMap(
moduleRoot,
mainModuleMap,
externalModuleMap,
_alreadyVisited,
_prefix,
) {
if (!moduleRoot) return;

const alreadyVisited = _alreadyVisited || {},
prefix = _prefix;

if (alreadyVisited && alreadyVisited.hasOwnProperty(moduleRoot)) return;

alreadyVisited[moduleRoot] = true;

listDirectories(moduleRoot, ({ fileName, fullFileName, symbolic, external }) => {
if (symbolic)
return buildFullModuleMap(
resolvePath(fullFileName, 'node_modules'),
mainModuleMap,
externalModuleMap,
alreadyVisited,
);

const moduleMap = external ? externalModuleMap : mainModuleMap,
moduleName = prefix ? PATH.join(prefix, fileName) : fileName;

if (fileName.charAt(0) !== '@') moduleMap[moduleName] = fullFileName;
else
return buildFullModuleMap(
fullFileName,
mainModuleMap,
externalModuleMap,
alreadyVisited,
fileName,
);
});
}

function buildModuleResolutionMap() {
const moduleMap = {},
externalModuleMap = {};

buildFullModuleMap(baseModulePath, moduleMap, externalModuleMap);

// Root project modules take precedence over external modules
return Object.assign({}, externalModuleMap, moduleMap);
}

function findAlternateRoots(moduleRoot = baseModulePath, alternateRoots = [], _alreadyVisited) {
const alreadyVisited = _alreadyVisited || {};
if (alreadyVisited && alreadyVisited.hasOwnProperty(moduleRoot)) return;

alreadyVisited[moduleRoot] = true;

listDirectories(moduleRoot, ({ fullFileName, fileName, external }) => {
if (fileName.charAt(0) !== '@') {
if (external) alternateRoots.push(fullFileName);
} else {
findAlternateRoots(fullFileName, alternateRoots, alreadyVisited);
}
});

return alternateRoots;
}

function getPolyfillHelper() {
let getPolyfills;

// Get default react-native polyfills
try {
getPolyfills = require('react-native/rn-get-polyfills');
} catch (e) {
getPolyfills = () => [];
}

// See if project has custom polyfills, if so, include the PATH to them
try {
const customPolyfills = require.resolve('./polyfills.js');
getPolyfills = (function (originalGetPolyfills) {
return () => originalGetPolyfills().concat(customPolyfills);
})(getPolyfills);
} catch (e) {
//ignore
}

return getPolyfills;
}

const PATH = require('path');
const FS = require('fs'),
exclusionList = require('metro-config/src/defaults/exclusionList');
const blacklist = require('metro-config/src/defaults/exclusionList');

const repoDir = PATH.dirname(PATH.dirname(__dirname));
const extractLinkedPackages = require('stream-chat-react-native-core/metro-dev-helpers/extract-linked-packages');

const moduleExclusionList = [
new RegExp(repoDir + '/examples/ExpoMessaging/.*'),
new RegExp(repoDir + '/examples/SampleApp/.*'),
new RegExp(repoDir + '/examples/TypeScriptMessaging/.*'),
new RegExp(repoDir + '/expo-package/.*'),
new RegExp(repoDir + '/native-package/node_modules/.*'),
new RegExp(repoDir + '/node_modules/.*'),
],
baseModulePath = resolvePath(__dirname, 'node_modules'),
// watch alternate roots (outside of project root)
alternateRoots = findAlternateRoots(),
// build full module map for proper
// resolution of modules in external roots
extraNodeModules = buildModuleResolutionMap();
const projectRoot = PATH.resolve(__dirname);

if (alternateRoots && alternateRoots.length)
console.log('Found alternate project roots: ', alternateRoots);
const { alternateRoots, extraNodeModules, moduleBlacklist } = extractLinkedPackages(projectRoot);

module.exports = {
resolver: {
blacklistRE: exclusionList(moduleExclusionList),
blacklistRE: blacklist(moduleBlacklist),
extraNodeModules,
useWatchman: false,
},
watchFolders: [PATH.resolve(__dirname)].concat(alternateRoots),
// transformer: {
// babelTransformerPath: require.resolve('./compiler/transformer'),
// },
serializer: {
getPolyfills: getPolyfillHelper(),
},
watchFolders: [projectRoot].concat(alternateRoots),
};
Loading