fix: ensure submenu is aligned correctly in reference to the parent menu with floating-ui/react #2868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enu with floating-ui/react
MartinCupela
requested review from
arnautov-anton and
oliverlaz
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2868 +/- ##
=======================================
Coverage 81.47% 81.47%
=======================================
Files 496 496
Lines 10056 10057 +1
Branches 2300 2301 +1
=======================================
+ Hits 8193 8194 +1
Misses 1743 1743
Partials 120 120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Size Change: +536 B (+0.05%) Total Size: 1.18 MB
ℹ️ View Unchanged
|
oliverlaz
approved these changes
Oct 17, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
## [13.10.0](v13.9.0...v13.10.0) (2025-10-23) ### Bug Fixes * control SimpleAttachmentSelector display according to channel capabilities ([#2860](#2860)) ([da9f02e](da9f02e)) * disable reply count button when missing send-reply permission ([#2871](#2871)) ([9e70560](9e70560)) * ensure message delivery data are recalculated for the latest message delivery confirmation ([#2869](#2869)) ([26cb181](26cb181)) * ensure submenu is aligned correctly in reference to the parent menu with floating-ui/react ([#2868](#2868)) ([fe84cf9](fe84cf9)) * exclude own read state from delivery status inference in ChannelPreview ([#2870](#2870)) ([2e9bc6e](2e9bc6e)) * use the nearest dialog manager to display dialogs ([#2865](#2865)) ([e4081c8](e4081c8)) ### Features * add optional remarkIgnoreMarkdown plugin to avoid markdown transform to HTML ([#2872](#2872)) ([33c6678](33c6678)) ### Chores * **deps:** bump axios from 1.9.0 to 1.12.2 in /examples/tutorial ([#2846](#2846)) ([3377c24](3377c24)) * **deps:** upgrade @stream-io/stream-chat-css to v5.15.0 ([cf3ad0f](cf3ad0f)) * **deps:** upgrade stream-chat to v9.25.0 ([419140c](419140c))
|
🎉 This PR is included in version 13.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Prevent submenu overlapping with the parent menu:
While popper-react was solving this automatically, floating-ui/react needs a more control over the behavior.
🛠 Implementation details
strategy: 'fixed'when reference and floating elements are in different roots (portals)flipfor side placements (left*/right*)