-
Notifications
You must be signed in to change notification settings - Fork 292
v9.4.0 #1700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
v9.4.0 #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MartinCupela
commented
Aug 3, 2022
- feat: allow to send custom message data when editing a message (feat: allow to send custom message data when editing a message #1696)
- fix: detect mentions of users who have email as their name (fix: detect mentions of users who have email as their name #1698)
The link detection process kicks in before user mentions are detected. With this change, while detecting links we also consider whether the detected link matches an email identical to the mentioned user's name. As part of this change, mdast-util-find-and-replace is updated to its latest version as the one we were previously using had a bug, and sometimes it could skip matching nodes.
* feat: allow to send custom message data when updating a message * test: verify that custom message data is sent with new & updated messages * docs: add note describing a possibility to pass customMessagData do handleSubmit
oliverlaz
approved these changes
Aug 3, 2022
arnautov-anton
approved these changes
Aug 3, 2022
|
Size Change: +4.27 kB (0%) Total Size: 1.55 MB
ℹ️ View Unchanged
|
Codecov Report
@@ Coverage Diff @@
## master #1700 +/- ##
==========================================
+ Coverage 79.39% 79.70% +0.30%
==========================================
Files 229 229
Lines 5796 5803 +7
Branches 1710 1713 +3
==========================================
+ Hits 4602 4625 +23
+ Misses 1048 1031 -17
- Partials 146 147 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
|
🎉 This PR is included in version 9.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.