fix: avoid race condition crash in jumping #1738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlaz
approved these changes
Sep 8, 2022
Codecov Report
@@ Coverage Diff @@
## develop #1738 +/- ##
===========================================
- Coverage 79.63% 79.59% -0.04%
===========================================
Files 231 231
Lines 5795 5799 +4
Branches 1643 1644 +1
===========================================
+ Hits 4615 4616 +1
- Misses 1039 1042 +3
Partials 141 141
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
|
I did! But how was this a production-only issue? |
szuperaz
approved these changes
Sep 8, 2022
arnautov-anton
approved these changes
Sep 8, 2022
Contributor
Author
@szuperaz I could not fully confirm that, but my guess is that this was somehow mitigated by React running effects twice in development :(. |
Contributor
Author
|
🎉 This PR is included in version 9.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
Author
|
🎉 This PR is included in version 9.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This change fixes a production-only issue where rapid jumping between messages created a race condition + exception.
@szuperaz - more of an FYI if you copied this mistake from me :(.