Skip to content

Conversation

@MartinCupela
Copy link
Contributor

MartinCupela and others added 10 commits January 4, 2023 11:34
* refactor(useScrollLocationLogic): remove unused param currentUserId

* fix: adjust scrollTop on new message batch load while beyond the InfiniteScroll threshold

* fix: return Promise from loadNextPage loadPreviousPage

* fix: avoid new pagination requests in InfiniteScroll while the previous request still in flight

* refactor: remove unused & undocumented InfiniteScroll prop pageStart

* refactor: remove unused & undocumented InfiniteScroll prop initialLoad

* fix: get scrollTop value directly from listElement to adjust the scroll position

* fix: get scrollTop value directly from listElement to adjust the scroll position

* test(InfiniteScroll): make pagination function spies to return a Promise

* test(useMessageListScrollManager): remove unit test file

* test(e2e): verify the MessageList pagination does not lead to content jumping

* fix: register loadMore scroll listener for infinite scroll with useLayoutEffect

* Revert "refactor: remove unused & undocumented InfiniteScroll prop initialLoad"

This reverts commit 5ddad56.

* fix: do not force the loadNextPage and loadPreviousPage function to return a Promise

* fix: revert loadMore, loadMoreNewer back to non-async

* Revert "test(useMessageListScrollManager): remove unit test file"

This reverts commit 1a21be8.

* refactor: revert useMessageListScrollManager to use onScrollBy and scrollContainerMeasures params

* test: execute useMessageListScrollManager tests with new param loadMoreScrollThreshold

* Revert "test(InfiniteScroll): make pagination function spies to return a Promise"

This reverts commit 9b46955.

* Revert "fix: return Promise from loadNextPage loadPreviousPage"

This reverts commit 5338f02.

* docs: remove message-list-hooks.mdx
…1891)

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1892)

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [json5](https://github.com/json5/json5) from 2.2.0 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v2.2.0...v2.2.3)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1894)

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps-dev): bump stream-chat from 7.1.0 to 8.2.1

Bumps [stream-chat](https://github.com/GetStream/stream-chat-js) from 7.1.0 to 8.2.1.
- [Release notes](https://github.com/GetStream/stream-chat-js/releases)
- [Changelog](https://github.com/GetStream/stream-chat-js/blob/master/CHANGELOG.md)
- [Commits](GetStream/stream-chat-js@v7.1.0...v8.2.1)

---
updated-dependencies:
- dependency-name: stream-chat
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(deps): remove stream-chat ^7.1.0 from peerDependencies

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: MartinCupela <martin.cupela@gmail.com>
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 83.46% // Head: 83.51% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (f2aeeee) compared to base (0441789).
Patch coverage: 90.90% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1896      +/-   ##
==========================================
+ Coverage   83.46%   83.51%   +0.05%     
==========================================
  Files         259      259              
  Lines        6410     6412       +2     
  Branches     1806     1808       +2     
==========================================
+ Hits         5350     5355       +5     
+ Misses        891      887       -4     
- Partials      169      170       +1     
Impacted Files Coverage Δ
...nents/MessageList/hooks/useScrollLocationLogic.tsx 56.81% <ø> (ø)
src/components/Chat/Chat.tsx 96.66% <50.00%> (-3.34%) ⬇️
...ponents/InfiniteScrollPaginator/InfiniteScroll.tsx 92.72% <100.00%> (+1.81%) ⬆️
src/components/MessageList/MessageList.tsx 85.36% <100.00%> (+0.18%) ⬆️
...s/MessageList/hooks/useMessageListScrollManager.ts 97.05% <100.00%> (ø)
.../components/MessageList/VirtualizedMessageList.tsx 65.67% <0.00%> (+1.49%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Size Change: +557 B (0%)

Total Size: 1.85 MB

Filename Size Change
./dist/browser.full-bundle.js 725 kB +155 B (0%)
./dist/browser.full-bundle.min.js 438 kB +79 B (0%)
./dist/components/Chat/Chat.js 933 B +30 B (+3%)
./dist/components/InfiniteScrollPaginator/InfiniteScroll.js 1.63 kB +1 B (0%)
./dist/components/MessageList/hooks/useMessageListScrollManager.js 916 B +73 B (+9%) 🔍
./dist/components/MessageList/hooks/useScrollLocationLogic.js 887 B +20 B (+2%)
./dist/components/MessageList/MessageList.js 3.91 kB +49 B (+1%)
./dist/css/index.css 28.2 kB -2 B (0%)
./dist/index.cjs.js 335 kB +152 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/components/Attachment/attachment-sizing.js 1.08 kB
./dist/components/Attachment/Attachment.js 1.37 kB
./dist/components/Attachment/AttachmentActions.js 472 B
./dist/components/Attachment/AttachmentContainer.js 2.17 kB
./dist/components/Attachment/Audio.js 1.79 kB
./dist/components/Attachment/Card.js 1.91 kB
./dist/components/Attachment/DownloadButton.js 259 B
./dist/components/Attachment/FileAttachment.js 550 B
./dist/components/Attachment/FileSizeIndicator.js 240 B
./dist/components/Attachment/hooks/useAudioController.js 612 B
./dist/components/Attachment/icons.js 573 B
./dist/components/Attachment/index.js 98 B
./dist/components/Attachment/utils.js 1.78 kB
./dist/components/AutoCompleteTextarea/Header.js 332 B
./dist/components/AutoCompleteTextarea/index.js 157 B
./dist/components/AutoCompleteTextarea/Item.js 497 B
./dist/components/AutoCompleteTextarea/List.js 1.62 kB
./dist/components/AutoCompleteTextarea/Textarea.js 6.4 kB
./dist/components/AutoCompleteTextarea/types.js 31 B
./dist/components/AutoCompleteTextarea/utils.js 834 B
./dist/components/Avatar/Avatar.js 738 B
./dist/components/Avatar/index.js 46 B
./dist/components/Channel/Channel.js 7.94 kB
./dist/components/Channel/channelState.js 1.29 kB
./dist/components/Channel/emojiData.js 602 B
./dist/components/Channel/hooks/useChannelContainerClasses.js 353 B
./dist/components/Channel/hooks/useCreateChannelStateContext.js 1.39 kB
./dist/components/Channel/hooks/useCreateTypingContext.js 194 B
./dist/components/Channel/hooks/useEditMessageHandler.js 236 B
./dist/components/Channel/hooks/useIsMounted.js 168 B
./dist/components/Channel/hooks/useMentionsHandlers.js 422 B
./dist/components/Channel/index.js 117 B
./dist/components/Channel/LoadingChannel.js 360 B
./dist/components/Channel/utils.js 478 B
./dist/components/ChannelHeader/ChannelHeader.js 896 B
./dist/components/ChannelHeader/icons.js 458 B
./dist/components/ChannelHeader/index.js 53 B
./dist/components/ChannelList/ChannelList.js 3.84 kB
./dist/components/ChannelList/ChannelListMessenger.js 448 B
./dist/components/ChannelList/hooks/index.js 196 B
./dist/components/ChannelList/hooks/useChannelDeletedListener.js 554 B
./dist/components/ChannelList/hooks/useChannelHiddenListener.js 553 B
./dist/components/ChannelList/hooks/useChannelTruncatedListener.js 482 B
./dist/components/ChannelList/hooks/useChannelUpdatedListener.js 832 B
./dist/components/ChannelList/hooks/useChannelVisibleListener.js 1.5 kB
./dist/components/ChannelList/hooks/useConnectionRecoveredListener.js 236 B
./dist/components/ChannelList/hooks/useMessageNewListener.js 649 B
./dist/components/ChannelList/hooks/useMobileNavigation.js 276 B
./dist/components/ChannelList/hooks/useNotificationAddedToChannelListener.js 1.59 kB
./dist/components/ChannelList/hooks/useNotificationMessageNewListener.js 1.58 kB
./dist/components/ChannelList/hooks/useNotificationRemovedFromChannelListener.js 369 B
./dist/components/ChannelList/hooks/usePaginatedChannels.js 2.04 kB
./dist/components/ChannelList/hooks/useUserPresenceChangedListener.js 569 B
./dist/components/ChannelList/index.js 78 B
./dist/components/ChannelList/utils.js 1.41 kB
./dist/components/ChannelPreview/ChannelPreview.js 1 kB
./dist/components/ChannelPreview/ChannelPreviewMessenger.js 881 B
./dist/components/ChannelPreview/hooks/index.js 66 B
./dist/components/ChannelPreview/hooks/useChannelPreviewInfo.js 431 B
./dist/components/ChannelPreview/hooks/useIsChannelMuted.js 280 B
./dist/components/ChannelPreview/index.js 81 B
./dist/components/ChannelPreview/utils.js 695 B
./dist/components/ChannelSearch/ChannelSearch.js 1.26 kB
./dist/components/ChannelSearch/hooks/useChannelSearch.js 3.07 kB
./dist/components/ChannelSearch/icons.js 701 B
./dist/components/ChannelSearch/index.js 85 B
./dist/components/ChannelSearch/SearchBar.js 1.56 kB
./dist/components/ChannelSearch/SearchInput.js 335 B
./dist/components/ChannelSearch/SearchResults.js 1.54 kB
./dist/components/ChannelSearch/utils.js 89 B
./dist/components/Chat/hooks/useChannelsQueryState.js 197 B
./dist/components/Chat/hooks/useChat.js 2.35 kB
./dist/components/Chat/hooks/useCreateChatContext.js 628 B
./dist/components/Chat/hooks/useCustomStyles.js 649 B
./dist/components/Chat/index.js 71 B
./dist/components/ChatAutoComplete/ChatAutoComplete.js 1.06 kB
./dist/components/ChatAutoComplete/index.js 56 B
./dist/components/ChatDown/ChatDown.js 530 B
./dist/components/ChatDown/icons.js 1.26 kB
./dist/components/ChatDown/index.js 48 B
./dist/components/CommandItem/CommandItem.js 265 B
./dist/components/CommandItem/index.js 51 B
./dist/components/DateSeparator/DateSeparator.js 502 B
./dist/components/DateSeparator/index.js 53 B
./dist/components/EmoticonItem/EmoticonItem.js 417 B
./dist/components/EmoticonItem/index.js 52 B
./dist/components/EmptyStateIndicator/EmptyStateIndicator.js 458 B
./dist/components/EmptyStateIndicator/icons.js 323 B
./dist/components/EmptyStateIndicator/index.js 59 B
./dist/components/EventComponent/EventComponent.js 959 B
./dist/components/EventComponent/index.js 52 B
./dist/components/Gallery/Gallery.js 1.16 kB
./dist/components/Gallery/Image.js 784 B
./dist/components/Gallery/index.js 64 B
./dist/components/Gallery/ModalGallery.js 341 B
./dist/components/index.js 281 B
./dist/components/InfiniteScrollPaginator/index.js 54 B
./dist/components/Loading/index.js 76 B
./dist/components/Loading/LoadingChannels.js 285 B
./dist/components/Loading/LoadingErrorIndicator.js 366 B
./dist/components/Loading/LoadingIndicator.js 679 B
./dist/components/LoadMore/index.js 68 B
./dist/components/LoadMore/LoadMoreButton.js 479 B
./dist/components/LoadMore/LoadMorePaginator.js 444 B
./dist/components/Message/FixedHeightMessage.js 1.7 kB
./dist/components/Message/hooks/index.js 134 B
./dist/components/Message/hooks/useActionHandler.js 1.69 kB
./dist/components/Message/hooks/useDeleteHandler.js 1.42 kB
./dist/components/Message/hooks/useEditHandler.js 300 B
./dist/components/Message/hooks/useFlagHandler.js 1.57 kB
./dist/components/Message/hooks/useMentionsHandler.js 387 B
./dist/components/Message/hooks/useMuteHandler.js 1.75 kB
./dist/components/Message/hooks/useOpenThreadHandler.js 266 B
./dist/components/Message/hooks/usePinHandler.js 1.87 kB
./dist/components/Message/hooks/useReactionHandler.js 3.23 kB
./dist/components/Message/hooks/useRetryHandler.js 1.16 kB
./dist/components/Message/hooks/useUserHandler.js 223 B
./dist/components/Message/hooks/useUserRole.js 735 B
./dist/components/Message/icons.js 1.63 kB
./dist/components/Message/index.js 156 B
./dist/components/Message/Message.js 2.27 kB
./dist/components/Message/MessageDeleted.js 374 B
./dist/components/Message/MessageOptions.js 900 B
./dist/components/Message/MessageRepliesCountButton.js 523 B
./dist/components/Message/MessageSimple.js 2.25 kB
./dist/components/Message/MessageStatus.js 1.23 kB
./dist/components/Message/MessageText.js 1.06 kB
./dist/components/Message/MessageTimestamp.js 546 B
./dist/components/Message/QuotedMessage.js 742 B
./dist/components/Message/types.js 31 B
./dist/components/Message/utils.js 2.81 kB
./dist/components/MessageActions/index.js 62 B
./dist/components/MessageActions/MessageActions.js 1.47 kB
./dist/components/MessageActions/MessageActionsBox.js 1.33 kB
./dist/components/MessageInput/AttachmentPreviewList.js 1.07 kB
./dist/components/MessageInput/CooldownTimer.js 352 B
./dist/components/MessageInput/DefaultTriggerProvider.js 586 B
./dist/components/MessageInput/DropzoneProvider.js 691 B
./dist/components/MessageInput/EditMessageForm.js 1.17 kB
./dist/components/MessageInput/EmojiPicker.js 619 B
./dist/components/MessageInput/hooks/index.js 78 B
./dist/components/MessageInput/hooks/useAttachments.js 976 B
./dist/components/MessageInput/hooks/useCommandTrigger.js 759 B
./dist/components/MessageInput/hooks/useCooldownTimer.js 859 B
./dist/components/MessageInput/hooks/useCreateMessageInputContext.js 1.33 kB
./dist/components/MessageInput/hooks/useEmojiIndex.js 268 B
./dist/components/MessageInput/hooks/useEmojiPicker.js 766 B
./dist/components/MessageInput/hooks/useEmojiTrigger.js 500 B
./dist/components/MessageInput/hooks/useFileState.js 169 B
./dist/components/MessageInput/hooks/useFileUploads.js 2.04 kB
./dist/components/MessageInput/hooks/useImageUploads.js 2.26 kB
./dist/components/MessageInput/hooks/useMessageInputState.js 2.59 kB
./dist/components/MessageInput/hooks/useMessageInputText.js 873 B
./dist/components/MessageInput/hooks/usePasteHandler.js 1.55 kB
./dist/components/MessageInput/hooks/useSubmitHandler.js 3.1 kB
./dist/components/MessageInput/hooks/useUserTrigger.js 2.88 kB
./dist/components/MessageInput/hooks/utils.js 2.5 kB
./dist/components/MessageInput/icons.js 2.83 kB
./dist/components/MessageInput/index.js 171 B
./dist/components/MessageInput/MessageInput.js 732 B
./dist/components/MessageInput/MessageInputFlat.js 2.7 kB
./dist/components/MessageInput/MessageInputSmall.js 1.77 kB
./dist/components/MessageInput/QuotedMessagePreview.js 916 B
./dist/components/MessageInput/UploadsPreview.js 862 B
./dist/components/MessageList/ConnectionStatus.js 428 B
./dist/components/MessageList/CustomNotification.js 276 B
./dist/components/MessageList/GiphyPreviewMessage.js 197 B
./dist/components/MessageList/hooks/index.js 164 B
./dist/components/MessageList/hooks/useEnrichedMessages.js 645 B
./dist/components/MessageList/hooks/useGiphyPreview.js 382 B
./dist/components/MessageList/hooks/useLastReadData.js 266 B
./dist/components/MessageList/hooks/useMessageListElements.js 1.22 kB
./dist/components/MessageList/hooks/useNewMessageNotification.js 691 B
./dist/components/MessageList/hooks/usePrependMessagesCount.js 643 B
./dist/components/MessageList/hooks/useShouldForceScrollToBottom.js 384 B
./dist/components/MessageList/icons.js 368 B
./dist/components/MessageList/index.js 172 B
./dist/components/MessageList/MessageListMainPanel.js 258 B
./dist/components/MessageList/MessageListNotifications.js 455 B
./dist/components/MessageList/MessageNotification.js 293 B
./dist/components/MessageList/ScrollToBottomButton.js 1.08 kB
./dist/components/MessageList/utils.js 2.78 kB
./dist/components/MessageList/VirtualizedMessageList.js 5.73 kB
./dist/components/MML/index.js 43 B
./dist/components/MML/MML.js 1.36 kB
./dist/components/Modal/icons.js 435 B
./dist/components/Modal/index.js 45 B
./dist/components/Modal/Modal.js 776 B
./dist/components/Reactions/hooks/useProcessReactions.js 1.06 kB
./dist/components/Reactions/index.js 74 B
./dist/components/Reactions/ReactionSelector.js 2.2 kB
./dist/components/Reactions/ReactionsList.js 1.57 kB
./dist/components/Reactions/SimpleReactionsList.js 1.72 kB
./dist/components/Reactions/utils/utils.js 116 B
./dist/components/SafeAnchor/index.js 74 B
./dist/components/SafeAnchor/SafeAnchor.js 304 B
./dist/components/Thread/icons.js 370 B
./dist/components/Thread/index.js 71 B
./dist/components/Thread/Thread.js 1.57 kB
./dist/components/Thread/ThreadHead.js 460 B
./dist/components/Thread/ThreadHeader.js 475 B
./dist/components/Thread/ThreadStart.js 283 B
./dist/components/Tooltip/hooks/index.js 61 B
./dist/components/Tooltip/hooks/useEnterLeaveHandlers.js 305 B
./dist/components/Tooltip/index.js 47 B
./dist/components/Tooltip/Tooltip.js 746 B
./dist/components/TypingIndicator/index.js 55 B
./dist/components/TypingIndicator/TypingIndicator.js 1.22 kB
./dist/components/UserItem/index.js 48 B
./dist/components/UserItem/UserItem.js 628 B
./dist/components/Window/index.js 46 B
./dist/components/Window/Window.js 352 B
./dist/constants/limits.js 96 B
./dist/constants/messageTypes.js 99 B
./dist/context/ChannelActionContext.js 730 B
./dist/context/ChannelStateContext.js 726 B
./dist/context/ChatContext.js 714 B
./dist/context/ComponentContext.js 721 B
./dist/context/DefaultEmoji.js 119 B
./dist/context/DefaultEmojiPicker.js 124 B
./dist/context/EmojiContext.js 943 B
./dist/context/index.js 123 B
./dist/context/MessageContext.js 721 B
./dist/context/MessageInputContext.js 350 B
./dist/context/TranslationContext.js 928 B
./dist/context/TypingContext.js 722 B
./dist/context/utils/getDisplayName.js 102 B
./dist/css/v2/index.css 19.1 kB
./dist/css/v2/index.layout.css 6.88 kB
./dist/i18n/de.json 1.62 kB
./dist/i18n/en.json 1.1 kB
./dist/i18n/es.json 1.64 kB
./dist/i18n/fr.json 1.66 kB
./dist/i18n/hi.json 1.82 kB
./dist/i18n/index.js 67 B
./dist/i18n/it.json 1.63 kB
./dist/i18n/ja.json 1.81 kB
./dist/i18n/ko.json 1.76 kB
./dist/i18n/nl.json 1.56 kB
./dist/i18n/pt.json 1.57 kB
./dist/i18n/ru.json 1.98 kB
./dist/i18n/Streami18n.js 6.69 kB
./dist/i18n/tr.json 1.58 kB
./dist/i18n/translations.js 172 B
./dist/i18n/utils.js 528 B
./dist/index.js 109 B
./dist/stories/add-message.stories.js 779 B
./dist/stories/attachment-sizing.stories.js 2.67 kB
./dist/stories/edit-message.stories.js 779 B
./dist/stories/hello.stories.js 652 B
./dist/stories/jump-to-message.stories.js 1.57 kB
./dist/stories/mark-read.stories.js 778 B
./dist/stories/message-status-readby-tooltip.stories.js 890 B
./dist/stories/navigate-long-message-lists.stories.js 2.67 kB
./dist/stories/pin-message.stories.js 1.72 kB
./dist/stories/toggle-message-actions.stories.js 673 B
./dist/stories/utils.js 731 B
./dist/stream-emoji.json 53 kB
./dist/types/types.js 31 B
./dist/utils.js 3.75 kB
./dist/utils/deprecationWarning.js 317 B
./dist/version.js 60 B

compressed-size-action

@MartinCupela MartinCupela requested review from petyosi and removed request for petyosi January 5, 2023 08:35
@MartinCupela MartinCupela merged commit 858d856 into master Jan 5, 2023
@petyosi
Copy link
Contributor

petyosi commented Jan 5, 2023

🎉 This PR is included in version 10.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants