Skip to content

fix: check the presence of remindMe and saveForLater message actions correctly #2808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
+18 −4
Merged

fix: check the presence of remindMe and saveForLater message actions correctly #2808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/components/Message/__tests__/utils.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,20 @@ describe('Message utils', () => {
);
});

it('should return message actions specified in custom actions array depending on channel config if actions are set to true', () => {
const result = getMessageActions(['remindMe'], defaultCapabilities, {
user_message_reminders: true,
});
expect(result).toStrictEqual(['remindMe']);
});

it('should return message actions specified in custom actions array depending on channel config if actions are set to true', () => {
const result = getMessageActions(['saveForLater'], defaultCapabilities, {
user_message_reminders: true,
});
expect(result).toStrictEqual(['saveForLater']);
});

it('should include reminder actions if enabled in channel config', () => {
const result = getMessageActions(true, defaultCapabilities, {
user_message_reminders: true,
Expand Down Expand Up @@ -137,9 +151,9 @@ describe('Message utils', () => {
};
const result = getMessageActions(actions, capabilities);
if (capabilityValue) {
expect(result).toContain(action);
expect(result).toStrictEqual([action]);
} else {
expect(result).not.toContain(action);
expect(result).not.toStrictEqual([action]);
}
});
});
Expand Down
4 changes: 2 additions & 2 deletions src/components/Message/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ export const getMessageActions = (

if (
channelConfig?.['user_message_reminders'] &&
messageActions.indexOf(MESSAGE_ACTIONS.remindMe)
messageActions.indexOf(MESSAGE_ACTIONS.remindMe) > -1
) {
messageActionsAfterPermission.push(MESSAGE_ACTIONS.remindMe);
}
Expand All @@ -213,7 +213,7 @@ export const getMessageActions = (

if (
channelConfig?.['user_message_reminders'] &&
messageActions.indexOf(MESSAGE_ACTIONS.saveForLater)
messageActions.indexOf(MESSAGE_ACTIONS.saveForLater) > -1
) {
messageActionsAfterPermission.push(MESSAGE_ACTIONS.saveForLater);
}
Expand Down