Skip to content

test: fix virtual list snapshotting #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2020
Merged

test: fix virtual list snapshotting #572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/MessageList/__tests__/VirtualizedMessageList.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jest.mock('react-virtuoso', () => {
const { forwardRef } = jest.requireActual('react');
return {
Virtuoso: forwardRef((props, ref) => (
<Virtuoso ref={ref} {...props} initialItemCount={10} />
<Virtuoso ref={ref} {...props} initialItemCount={20} />
)),
};
});
Expand Down Expand Up @@ -50,7 +50,7 @@ async function createChannel() {
const mockedChannel = generateChannel({
members: [generateMember({ user: user1 }), generateMember({ user: user2 })],
messages: ' '
.repeat(100)
.repeat(20)
.split(' ')
.map((v, i) => generateMessage({ user: i % 3 ? user1 : user2 })),
});
Expand Down
58 changes: 2 additions & 56 deletions src/components/MessageList/__tests__/__snapshots__/VirtualizedMessageList.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,40 +242,13 @@ exports[`VirtualizedMessageList should render empty list of messages 1`] = `
false
</div>
</div>
<div
data-index={21}
data-known-size={30}
>
<div>
FixedHeightMessage groupedByUser:
false
</div>
</div>
<div
data-index={22}
data-known-size={30}
>
<div>
FixedHeightMessage groupedByUser:
false
</div>
</div>
<div
data-index={23}
data-known-size={30}
>
<div>
FixedHeightMessage groupedByUser:
false
</div>
</div>
<footer />
</div>
</div>
<div
style={
Object {
"height": "3030px",
"height": "630px",
"position": "absolute",
"top": 0,
}
Expand Down Expand Up @@ -542,33 +515,6 @@ exports[`VirtualizedMessageList should render empty list of messages with messag
true
</div>
</div>
<div
data-index={21}
data-known-size={30}
>
<div>
FixedHeightMessage groupedByUser:
false
</div>
</div>
<div
data-index={22}
data-known-size={30}
>
<div>
FixedHeightMessage groupedByUser:
false
</div>
</div>
<div
data-index={23}
data-known-size={30}
>
<div>
FixedHeightMessage groupedByUser:
true
</div>
</div>
<footer>
<div>
TypingIndicator
Expand All @@ -579,7 +525,7 @@ exports[`VirtualizedMessageList should render empty list of messages with messag
<div
style={
Object {
"height": "3030px",
"height": "630px",
"position": "absolute",
"top": 0,
}
Expand Down