Skip to content

Conversation

@ath92
Copy link

@ath92 ath92 commented Mar 16, 2021

  • Fixes regression around keyboard navigation in suggestions list (scroll position was no longer being updated on lists that don't fit the container)
  • Fixes regression that caused the selected item to be reset to the first item (due to SuggestionListContainer being redefined in the render method of the Textarea component)
  • Fixes CSS issue where ReactionList would sometimes cover the suggestions from TextAreaAutocomplete

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

@ath92 ath92 requested a review from DanC5 March 16, 2021 16:01
@github-actions
Copy link

github-actions bot commented Mar 16, 2021

Size Change: +16 B (0%)

Total Size: 1.53 MB

Filename Size Change
./dist/browser.full-bundle.js 730 kB +6 B (0%)
./dist/browser.full-bundle.min.js 404 kB -4 B (0%)
./dist/css/index.css 28.6 kB +2 B (0%)
./dist/css/index.min.css 23.9 kB +4 B (0%)
./dist/index.es.js 165 kB +3 B (0%)
./dist/index.js 167 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/css/index.js 21 B 0 B
./dist/i18n/en.json 908 B 0 B
./dist/i18n/fr.json 1.39 kB 0 B
./dist/i18n/hi.json 1.57 kB 0 B
./dist/i18n/it.json 1.34 kB 0 B
./dist/i18n/nl.json 1.32 kB 0 B
./dist/i18n/ru.json 1.65 kB 0 B
./dist/i18n/tr.json 1.34 kB 0 B

compressed-size-action

…wn stacking context, so that reaction lists never cover the autocomplete suggestion list
@DanC5 DanC5 merged commit cb9d520 into master Mar 16, 2021
@DanC5 DanC5 deleted the CRS-442_emoji-keyboard-navigation branch March 16, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants