Skip to content

Conversation

@ath92
Copy link

@ath92 ath92 commented Mar 22, 2021

Found two bugs with image attachments:

  • single-attachment images didn't show up in the lightbox
    • (found out that we were setting both source and src for multiple-image galleries, but only source for single-attachment galleries, the latter seems to correspond to react-images types)
  • after clicking a thumbnail in a gallery with multiple images, it was impossible to close the lightbox

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

@ath92 ath92 requested review from DanC5 and ambaldwin March 22, 2021 14:12
@codecov-io
Copy link

codecov-io commented Mar 22, 2021

Codecov Report

Merging #795 (d9d10bd) into typescript-conversion (1e2b96f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                    Coverage Diff                    @@
##           typescript-conversion     #795      +/-   ##
=========================================================
- Coverage                  84.51%   84.51%   -0.01%     
=========================================================
  Files                        189      189              
  Lines                       4669     4668       -1     
  Branches                    1441     1440       -1     
=========================================================
- Hits                        3946     3945       -1     
  Misses                       523      523              
  Partials                     200      200              
Impacted Files Coverage Δ
src/components/Gallery/Gallery.tsx 88.00% <0.00%> (-0.47%) ⬇️
src/components/Gallery/ModalImage.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e2b96f...d9d10bd. Read the comment docs.

@DanC5 DanC5 merged commit 4a00e5c into typescript-conversion Mar 22, 2021
@DanC5 DanC5 deleted the fix-image-attachment-bugs branch March 22, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants