Skip to content

Fix broken composer input view scrolling after shrinking input #2788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2023
Merged

Fix broken composer input view scrolling after shrinking input #2788

merged 2 commits into from
Sep 18, 2023

Conversation

@nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Sep 18, 2023 •
edited
Loading

🔗 Issue Links

None

🎯 Goal

Fix regression while testing Release 4.37.0

🧪 Manual Testing Notes

  • Type a long message in the composer
  • The composer should be scrollable
  • Shrink the composer
  • The composer should still be scrollable and not move to a different place

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added 🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK labels Sep 18, 2023
@nuno-vieira nuno-vieira requested a review from a team as a code owner September 18, 2023 13:30
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

89.0% 89.0% Coverage
0.0% 0.0% Duplication

@nuno-vieira nuno-vieira enabled auto-merge (squash) September 18, 2023 14:10
@nuno-vieira nuno-vieira merged commit ea14281 into develop Sep 18, 2023
@nuno-vieira nuno-vieira deleted the fix/broken-composer-input-scrolling branch September 18, 2023 14:12
nuno-vieira added a commit that referenced this pull request Sep 18, 2023
@nuno-vieira
Fix broken composer input view scrolling after shrinking input (#2788)
65f7299 
* Fix broken composer input view scrolling after shrinking input

* Update CHANGELOG.md
@nuno-vieira nuno-vieira mentioned this pull request Sep 20, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ipavlidakis ipavlidakis ipavlidakis approved these changes

Assignees

No one assigned

Labels

🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nuno-vieira @ipavlidakis