Skip to content

Include current user in the more channel actions members list #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2025
Merged

Include current user in the more channel actions members list #1001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55c342e
Include current user in the more channel actions members list
laevandus Oct 7, 2025
f268340
CHANGELOG entry
laevandus Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Fix replying to unread messages marking them instantly as read [#989](https://github.com/GetStream/stream-chat-swiftui/pull/989)
- Fix rendering of the add users button on iOS 26 [#999](https://github.com/GetStream/stream-chat-swiftui/pull/999)
- Use `ColorPalette.navigationBarTint` for the background of the add users button [#999](https://github.com/GetStream/stream-chat-swiftui/pull/999)
- Fix showing all the channel members in the more channel actions view [#1001](https://github.com/GetStream/stream-chat-swiftui/pull/1001)

# [4.89.1](https://github.com/GetStream/stream-chat-swiftui/releases/tag/4.89.1)
_September 23, 2025_
Expand Down
4 changes: 1 addition & 3 deletions Sources/StreamChatSwiftUI/ChatChannelList/MoreChannelActionsViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,7 @@ open class MoreChannelActionsViewModel: ObservableObject {
) {
self.channelActions = channelActions
self.channel = channel
members = channel.lastActiveMembers.filter { [unowned self] member in
member.id != chatClient.currentUserId
}
members = channel.lastActiveMembers
}

/// Returns an image for a member.
Expand Down
12 changes: 8 additions & 4 deletions StreamChatSwiftUITests/Tests/ChatChannelList/MoreChannelActionsViewModel_Tests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,23 @@ class MoreChannelActionsViewModel_Tests: StreamChatTestCase {
streamChat = StreamChat(chatClient: chatClient, utils: utils)
}

func test_moreActionsVM_membersLoaded() {
func test_moreActionsVM_membersLoaded() throws {
// Given
let currentUserId = try XCTUnwrap(streamChat?.chatClient.currentUserId)
let memberId: String = .unique
let viewModel = makeMoreActionsViewModel(
members: [.mock(id: memberId, isOnline: true)]
members: [
.mock(id: memberId, isOnline: true),
.mock(id: currentUserId, isOnline: true)
]
)

// When
let members = viewModel.members

// Then
XCTAssert(members.count == 1)
XCTAssert(members[0].id == memberId)
XCTAssert(members.count == 2)
XCTAssert(members.map(\.id) == [memberId, currentUserId])
}

func test_moreActionsVM_chatHeaderInfo() {
Expand Down
Loading