Skip to content

Conversation

@gpunto
Copy link
Collaborator

@gpunto gpunto commented Nov 7, 2025

Goal

As mentioned in #25, I'm applying spotless in a separate PR

Implementation

Apply spotless

Testing

The check now passes

Checklist

  • Issue linked (if any)
  • Tests/docs updated
  • I have signed the Stream CLA (required for external contributors)

@gpunto gpunto requested a review from Copilot November 7, 2025 09:29
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@gpunto gpunto added the pr:internal Internal changes / housekeeping label Nov 7, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR applies consistent code formatting and style improvements across the codebase, including adding license headers to XML files, standardizing blank line placement after copyright notices, and enforcing trailing comma conventions.

Key Changes:

  • Added blank lines after license headers in all Kotlin files for consistency
  • Added copyright/license headers to XML resource files (AndroidManifest.xml, layout resources, etc.)
  • Added trailing commas to function calls in Gradle build files following Kotlin style conventions

Reviewed Changes

Copilot reviewed 169 out of 169 changed files in this pull request and generated no comments.

File Description
All Kotlin source/test files Added blank line after license header (line 16) for consistent spacing
XML resource files (manifest, layouts, values) Added copyright/license header block
build.gradle.kts files Added trailing commas to multi-line function calls
MoshiProviderTest.kt Reformatted JSON string indentation in test case

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gpunto gpunto marked this pull request as ready for review November 7, 2025 09:36
@gpunto gpunto marked this pull request as draft November 7, 2025 13:37
Base automatically changed from plugins.spotless to develop November 17, 2025 09:37
@sonarqubecloud
Copy link

@VelikovPetar VelikovPetar requested a review from a team November 17, 2025 09:41
@VelikovPetar VelikovPetar marked this pull request as ready for review November 17, 2025 09:41
@VelikovPetar VelikovPetar merged commit cd0a959 into develop Nov 17, 2025
6 checks passed
@VelikovPetar VelikovPetar deleted the plugins.spotless.apply branch November 17, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:internal Internal changes / housekeeping

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants