feat(llc): Introduce type-safe filter #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the Stream Core library by introducing a new, type-safe approach to defining filters **Filter Enhancements:** - Introduced `FilterField` as an extension type for compile-time type safety in field definitions. - Reworked `Filter` class to be generic (`Filter<F extends FilterField>`), ensuring type safety and clarity. - Implemented specific operator classes (e.g., `EqualOperator`, `AndOperator`) that extend the base `Filter` class, providing a structured and type-safe way to build complex queries. - Added factory constructors to `Filter` (e.g., `Filter.equal`, `Filter.and`) for a more fluent and readable API when creating filters. - Updated `FilterOperator` to use an extension type for better type safety and organization. - Replaced the old `Filter` implementation with a new, more robust and type-safe system. **Sort Enhancements:** - Improved documentation and clarity for `Sort`, `SortField`, `SortDirection`, and `NullOrdering`. - Ensured consistency in how sort operations are defined and used. **General Changes:** - Updated tests to reflect the new filter and sort implementations, ensuring comprehensive coverage and correctness. - Improved overall code documentation and type annotations for better maintainability and developer experience. These changes provide a more robust, type-safe, and developer-friendly way to construct queries, reducing potential runtime errors and improving code readability.
renefloor
approved these changes
Sep 5, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 83.95% 87.05% +3.10%
==========================================
Files 5 4 -1
Lines 162 170 +8
==========================================
+ Hits 136 148 +12
+ Misses 26 22 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances the Stream Core library by introducing a new, type-safe approach to defining filters
Filter Enhancements:
FilterFieldas an extension type for compile-time type safety in field definitions.Filterclass to be generic (Filter<F extends FilterField>), ensuring type safety and clarity.EqualOperator,AndOperator) that extend the baseFilterclass, providing a structured and type-safe way to build complex queries.Filter(e.g.,Filter.equal,Filter.and) for a more fluent and readable API when creating filters.FilterOperatorto use an extension type for better type safety and organization.Filterimplementation with a new, more robust and type-safe system.Sort Enhancements:
Sort,SortField,SortDirection, andNullOrdering.General Changes:
These changes provide a more robust, type-safe, and developer-friendly way to construct queries, reducing potential runtime errors and improving code readability.