refactor(llc)!: Enhance WebSocket connection management and lifecycle handling #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… handling This commit introduces several improvements to the WebSocket connection management and application lifecycle handling: **WebSocket Engine:** - Ensures that any existing WebSocket connection is closed before opening a new one. - Improved handling of the `onDone` event for WebSocket streams, ensuring proper cleanup and notification. - Refined the `close` method to handle cases where the WebSocket is not open and to notify listeners appropriately. **WebSocket Client:** - Updated error handling during the connection opening process to use `recover` instead of `onFailure` for better resilience. - Simplified error handling in `onError` by directly calling `disconnect`. **Network and Lifecycle State:** - Renamed `AppLifecycleStateProvider` to `LifecycleStateProvider` and `AppLifecycleState` to `LifecycleState` for clarity and broader applicability. - Added an `unknown` state to both `NetworkState` and `LifecycleState` to represent initial or indeterminate states. - Introduced a `keepConnectionAliveInBackground` option in `ConnectionRecoveryHandler` to allow maintaining the WebSocket connection even when the app is in the background. - `ConnectionRecoveryHandler` now considers the `unknown` state for both network and lifecycle, taking no action in these cases. - `ConnectionRecoveryHandler` logic for `_onAppLifecycleStateChanged` updated to respect `keepConnectionAliveInBackground`. **General Changes:** - Updated imports and type aliases to reflect the renaming of lifecycle state components.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
=======================================
Coverage 87.05% 87.05%
=======================================
Files 4 4
Lines 170 170
=======================================
Hits 148 148
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
renefloor
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
Fixes: FLU-279
Description of the pull request
This PR introduces several improvements to the WebSocket connection management and application lifecycle handling:
WebSocket Engine:
onDoneevent for WebSocket streams, ensuring proper cleanup and notification.closemethod to handle cases where the WebSocket is not open and to notify listeners appropriately.WebSocket Client:
recoverinstead ofonFailurefor better resilience.onErrorby directly callingdisconnect.Network and Lifecycle State:
AppLifecycleStateProvidertoLifecycleStateProviderandAppLifecycleStatetoLifecycleStatefor clarity and broader applicability.unknownstate to bothNetworkStateandLifecycleStateto represent initial or indeterminate states.keepConnectionAliveInBackgroundoption inConnectionRecoveryHandlerto allow maintaining the WebSocket connection even when the app is in the background.ConnectionRecoveryHandlernow considers theunknownstate for both network and lifecycle, taking no action in these cases.ConnectionRecoveryHandlerlogic for_onAppLifecycleStateChangedupdated to respectkeepConnectionAliveInBackground.General Changes: