feat(llc): Add eagerError to uploadBatch #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces an `eagerError` parameter to the `uploadBatch` method in `AttachmentUploader`. When `eagerError` is true, the upload stream will throw an exception and close immediately upon the first failed upload. If `eagerError` is false (the default behavior), failed uploads will be emitted as `Result.failure` and the upload process will continue for the remaining attachments. Additionally, the `attachments` parameter in `uploadBatch` has been changed from `List<StreamAttachment>` to `Iterable<StreamAttachment>` for better flexibility. A similar change was made to the `merge` extension method.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
=======================================
Coverage 83.95% 83.95%
=======================================
Files 5 5
Lines 162 162
=======================================
Hits 136 136
Misses 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
renefloor
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces an
eagerErrorparameter to theuploadBatchmethod inAttachmentUploader.When
eagerErroris true, the upload stream will throw an exception and close immediately upon the first failed upload. IfeagerErroris false (the default behavior), failed uploads will be emitted asResult.failureand the upload process will continue for the remaining attachments.Additionally, the
attachmentsparameter inuploadBatchhas been changed fromList<StreamAttachment>toIterable<StreamAttachment>for better flexibility. A similar change was made to themergeextension method.