-
Notifications
You must be signed in to change notification settings - Fork 0
chore(repo): initial package and workflow setup #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d4d30b1 to
ef345f8
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Co-authored-by: Sahil Kumar <xdsahil@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove this action and use the one we created in core. So any fixes can happen at one place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah good idea, but let's take that as a separate task.
| - name: 📚 Git Checkout | ||
| uses: actions/checkout@v4 | ||
| - name: 📊 Verify Pana Score | ||
| uses: ./.github/actions/pana |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once removed, we can use our core action here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| uses: ./.github/actions/pana | |
| uses: GetStream/stream-core-flutter/.github/actions/pana |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions, Otherwise LGTM 🚀
This adds a basic stream_feeds package and workflows
For now we hope/assume we can publish this as
stream_feeds, otherwise we'll rename it tostream_feedat some point.