feat: add unseen, unread to notificationfeed response #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterdeme
force-pushed
the
unseen_unread
branch
from
b98c151 to
3726f7f
Compare
peterdeme
force-pushed
the
unseen_unread
branch
from
3726f7f to
704bfab
Compare
Contributor
|
@peterdeme can we handle this change in cloud client package ? |
Contributor
Author
|
@ferhatelmas I'm not familiar with it, how do I do that? |
Contributor
|
we need to cover changes here too https://github.com/GetStream/stream-java/blob/main/src/main/java/io/getstream/cloud/CloudNotificationFeed.java |
Contributor
|
@peterdeme nice but there is a failure at https://github.com/GetStream/stream-java/runs/5144459501?check_suite_focus=true#step:4:105 |
peterdeme
force-pushed
the
unseen_unread
branch
from
2373da4 to
26c82e4
Compare
Contributor
Author
|
@ferhatelmas fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including a fix for #101