-
Notifications
You must be signed in to change notification settings - Fork 48
feat: Add capabilities in batch client get enrichment activities to use Enrichment flags #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
xernobyl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hi @xernobyl @JcMinarro when will this changes can be release in new version? Thanks. |
I'll try to have it done in the next 8 hours. |
JcMinarro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message history doesn't follow the expected structure.
On this repository we are using CommitLint to check the commit message.
| #- name: Commit message lint | ||
| # uses: wagoid/commitlint-github-action@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it commented on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was me. I know it makes change logs prettier and all nice, but I get the idea that every time I there's a PR in a SDK there's a wrong commit message that needs to be fixed. I can revert if you disagree.
|
|
||
| group 'io.getstream.client' | ||
| version = '3.6.2' | ||
| version = '3.7.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version shouldn't be manual update.
There is a CI job for that
We need this PR pass the CI checks, could you fix them? |
|
Hi @JcMinarro @xernobyl please review here #127, I will close this PR. Thanks. |
No description provided.