Skip to content

Conversation

@adinovri
Copy link

No description provided.

Copy link
Contributor

@xernobyl xernobyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adinovri adinovri changed the title Add capabilities in batch client get enrichment activities to use Enrichment flags feat: Add capabilities in batch client get enrichment activities to use Enrichment flags Jul 11, 2023
@adinovri
Copy link
Author

Hi @xernobyl @JcMinarro when will this changes can be release in new version? Thanks.

@xernobyl
Copy link
Contributor

Hi @xernobyl @JcMinarro when will this changes can be release in new version? Thanks.

I'll try to have it done in the next 8 hours.

Copy link
Contributor

@JcMinarro JcMinarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message history doesn't follow the expected structure.
On this repository we are using CommitLint to check the commit message.

Comment on lines +19 to +20
#- name: Commit message lint
# uses: wagoid/commitlint-github-action@v4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it commented on?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was me. I know it makes change logs prettier and all nice, but I get the idea that every time I there's a PR in a SDK there's a wrong commit message that needs to be fixed. I can revert if you disagree.


group 'io.getstream.client'
version = '3.6.2'
version = '3.7.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version shouldn't be manual update.
There is a CI job for that

@JcMinarro
Copy link
Contributor

Hi @xernobyl @JcMinarro when will this changes can be release in new version? Thanks.

We need this PR pass the CI checks, could you fix them?

@adinovri
Copy link
Author

Hi @JcMinarro @xernobyl please review here #127, I will close this PR. Thanks.

@adinovri adinovri closed this Jul 12, 2023
@adinovri adinovri deleted the fix_batchGetEnrichActivities branch July 12, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants