Skip to content

feat: add capability in batch client to get enrichment activities to use enrichment flags #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2023
Merged

feat: add capability in batch client to get enrichment activities to use enrichment flags #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfcc86a
feat: add capability in batch client to get enrichment activities to …
Jul 12, 2023
dad14c7
fix: spotless
Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/main/java/io/getstream/client/BatchClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import io.getstream.core.exceptions.StreamException;
import io.getstream.core.http.Token;
import io.getstream.core.models.*;
import io.getstream.core.options.EnrichmentFlags;
import io.getstream.core.utils.DefaultOptions;
import java.util.List;
import java8.util.J8Arrays;
Expand Down Expand Up @@ -91,8 +92,13 @@ public CompletableFuture<List<EnrichedActivity>> getEnrichedActivitiesByID(

public CompletableFuture<List<EnrichedActivity>> getEnrichedActivitiesByID(String... activityIDs)
throws StreamException {
return getEnrichedActivitiesByID(DefaultOptions.DEFAULT_ENRICHMENT_FLAGS, activityIDs);
}

public CompletableFuture<List<EnrichedActivity>> getEnrichedActivitiesByID(
EnrichmentFlags flags, String... activityIDs) throws StreamException {
final Token token = buildActivityToken(secret, TokenAction.READ);
return batch.getEnrichedActivitiesByID(token, activityIDs);
return batch.getEnrichedActivitiesByID(token, flags, activityIDs);
}

public CompletableFuture<List<Activity>> getActivitiesByForeignID(
Expand Down
4 changes: 3 additions & 1 deletion src/main/java/io/getstream/core/StreamBatch.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import io.getstream.core.http.Token;
import io.getstream.core.models.*;
import io.getstream.core.options.CustomQueryParameter;
import io.getstream.core.options.EnrichmentFlags;
import io.getstream.core.options.RequestOption;
import java.io.IOException;
import java.net.MalformedURLException;
Expand Down Expand Up @@ -151,7 +152,7 @@ public CompletableFuture<List<Activity>> getActivitiesByID(Token token, String..
}

public CompletableFuture<List<EnrichedActivity>> getEnrichedActivitiesByID(
Token token, String... activityIDs) throws StreamException {
Token token, EnrichmentFlags flags, String... activityIDs) throws StreamException {
checkNotNull(activityIDs, "No activities to get");
checkArgument(activityIDs.length > 0, "No activities to get");

Expand All @@ -163,6 +164,7 @@ public CompletableFuture<List<EnrichedActivity>> getEnrichedActivitiesByID(
url,
key,
token,
flags,
new CustomQueryParameter("ids", Joiner.on(",").join(activityIDs))))
.thenApply(
response -> {
Expand Down