[PBE-000] update gradle #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xernobyl
force-pushed
the
assortedfixes
branch
from
40d0197 to
ce75ae5
Compare
kanat
reviewed
Aug 16, 2023
Comment on lines
+73
to
+77
| /*spotless { | ||
| java { | ||
| googleJavaFormat() | ||
| } | ||
| } | ||
| }*/ |
There was a problem hiding this comment.
Just curious what was the reason to comment out the spotless section 🤔
Contributor
Author
There was a problem hiding this comment.
It fails to run. There seem to be some version incompatibility issues / bugs. I'll do the necessary fixes to re-enable it on another PR as I didn't want to keep this waiting. It's passing the tests now, which weren't working correctly before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated gradle, spotless disabled temporarily, as it's causing errors. Skipped personalization tests.