Skip to content

[FEEDS-121]chore: batch delete soft reaction #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025
Merged

[FEEDS-121]chore: batch delete soft reaction #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba5d532
chore: batch delete soft reaction
Mar 21, 2025
26d028a
chore: fix tests
Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/main/java/io/getstream/core/models/BatchDeleteReactionsRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,24 @@
public class BatchDeleteReactionsRequest {

private final List<String> ids;
private final Boolean SoftDelete;


public BatchDeleteReactionsRequest(@JsonProperty("ids") List<String> ids) {
this.ids = ids;
SoftDelete = null;
}
public BatchDeleteReactionsRequest(@JsonProperty("ids") List<String> ids, @JsonProperty("soft_delete") Boolean softDelete) {
this.ids = ids;
SoftDelete = softDelete;
}

public List<String> getIds() {
return ids;
}

@JsonProperty("soft_delete")
public Boolean getSoftDelete() {
return SoftDelete;
}
}
45 changes: 41 additions & 4 deletions src/test/java/io/getstream/client/BatchDeleteActivitiesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,8 @@

import com.google.common.collect.Lists;
import io.getstream.core.http.Response;
import io.getstream.core.models.BatchDeleteActivitiesRequest;
import io.getstream.core.models.*;
import io.getstream.core.models.BatchDeleteActivitiesRequest.ActivityToDelete;
import io.getstream.core.models.Activity;
import io.getstream.core.models.BatchDeleteReactionsRequest;
import io.getstream.core.models.Reaction;
import io.getstream.core.options.Filter;
import io.getstream.core.options.Limit;
import java8.util.concurrent.CompletableFuture;
Expand Down Expand Up @@ -150,6 +147,46 @@ public void testDeleteReactions() throws Exception {


}
@Test
public void testSoftDeleteReactions() throws Exception {
String uuid1 = UUID.randomUUID().toString().replace("-", "");
FlatFeed feed = client.flatFeed("user", uuid1);

// Insert two activities
Activity activity1Res = feed.addActivity(Activity.builder()
.actor("user1")
.verb("post")
.object("object1")
.build()).join();

Activity activity2Res = feed.addActivity(Activity.builder()
.actor("user1")
.verb("like")
.object("object2")
.build()).join();

// Add reactions to both activities
Reaction u1 = client.reactions().add("user1", "like", activity1Res.getID()).join();
Reaction u2 = client.reactions().add("user2", "like", activity1Res.getID()).join();
Reaction u3 = client.reactions().add("user1", "like", activity2Res.getID()).join();
Reaction u4 = client.reactions().add("user2", "like", activity2Res.getID()).join();

// Verify reactions were created
assertNotNull(client.reactions().get(u1.getId()).join());
assertNotNull(client.reactions().get(u2.getId()).join());
assertNotNull(client.reactions().get(u3.getId()).join());
assertNotNull(client.reactions().get(u4.getId()).join());

// Soft delete reactions
BatchDeleteReactionsRequest deleteReactionsRequest =
new BatchDeleteReactionsRequest(Arrays.asList(u1.getId(), u2.getId(), u3.getId()), true);
client.deleteReactions(deleteReactionsRequest).join();

// Verify reactions can still be fetched
assertNotNull(client.reactions().get(u1.getId()).join());
assertNotNull(client.reactions().get(u2.getId()).join());
assertNotNull(client.reactions().get(u3.getId()).join());
}

@Test
public void testDeleteActivitiesMultipleFeeds() throws Exception {
Expand Down
Loading