Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion getstream/video/rtc/connection_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ async def _on_subscriber_offer(self, event: events_pb2.SubscriberOffer):
# Set the local description. aiortc will manage the SDP content.
with telemetry.start_as_current_span(
"rtc.on_subscriber_offer.set_local_description"
):
) as span:
await self.subscriber_pc.setLocalDescription(answer)

logger.debug(
Expand Down
11 changes: 7 additions & 4 deletions getstream/video/rtc/pc.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import aiortc
from aiortc.contrib.media import MediaRelay

from getstream.common import telemetry
from getstream.video.rtc.track_util import AudioTrackHandler
from pyee.asyncio import AsyncIOEventEmitter
from aiortc.rtcrtpsender import RTCRtpSender
Expand Down Expand Up @@ -84,10 +85,12 @@ async def handle_answer(self, response):
type="answer", sdp=response.sdp
)

await self.setRemoteDescription(remote_description)
logger.debug(
f"Publisher remote description set successfully. {self.localDescription}"
)
with telemetry.start_as_current_span("publisher.pc.handle_answer") as span:
span.set_attribute("remoteDescription", remote_description.sdp)
await self.setRemoteDescription(remote_description)
logger.debug(
f"Publisher remote description set successfully. {self.localDescription}"
)

async def wait_for_connected(self, timeout: float = 15.0):
# If already connected, return immediately
Expand Down
8 changes: 6 additions & 2 deletions getstream/video/rtc/peer_connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,12 +103,16 @@ async def add_tracks(
self.publisher_pc.addTrack(relayed_video)
logger.info(f"Added relayed video track {relayed_video.id}")

with telemetry.start_as_current_span("rtc.publisher_pc.create_offer"):
with telemetry.start_as_current_span(
"rtc.publisher_pc.create_offer"
) as span:
offer = await self.publisher_pc.createOffer()
span.set_attribute("sdp", offer.sdp)

with telemetry.start_as_current_span(
"rtc.publisher_pc.set_local_description"
):
) as span:
span.set_attribute("sdp", offer.sdp)
await self.publisher_pc.setLocalDescription(offer)

try:
Expand Down
Loading