Skip to content

Conversation

@dangusev
Copy link
Contributor

Problem

The code in twirp.logging.configure() sets the root logger's log level to INFO (the default is WARNING).
It makes INFO log messages from other libs visible by default, which creates noise.

This code is called when twirp.context.Context is created for the first time, unless the logger argument is provided to it.

Solution

  1. Added a custom video.rtc.twirp_client_wrapper.Context subclass that always provides the default logger, so the root logger remains intact.
  2. Replaced the usages of twirp.context.Context with video.rtc.twirp_client_wrapper.Context class

Copy link
Contributor

@yarikdevcom yarikdevcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbarbugli tbarbugli merged commit f722133 into main Oct 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants