Fix codegeneration flow

[tbarbugli]

Summary by CodeRabbit

• Chores
  • Loosened twirp dependency constraints to support broader version compatibility
  • Updated aiohttp dependency constraints for compatibility improvements
  • Enhanced WebRTC build and installation processes with improved validation

[coderabbitai]

Walkthrough

This PR refactors dependency management and build configuration. It removes the git-based twirp package from the release workflow, consolidates dependency installation into a single uv sync command in the build script, adds PATH validation for Go binaries, updates aiohttp version constraints, and loosens the twirp version requirement.

Changes

Cohort / File(s)	Summary
Release Workflow Configuration .github/workflows/release.yml	Adds a pre-sync step to remove the git-based twirp package from the dev group using uv before executing uv sync.
Build Script Updates generate_webrtc.sh	Replaces explicit dependency installation commands with consolidated uv sync --all-extras --dev --all-packages; forces submodule addition with -f flag; changes protoc error message from "protocol/install.sh" to "brew install protoc"; refactors twirp generator installation from direct go install to guarded block with PATH validation; adds check to ensure Go binaries directory is in PATH.
Project Dependencies pyproject.toml	Loosens twirp version constraint from >=0.0.7 to no version specification across two webrtc optional-dependency blocks; updates aiohttp constraint from >=3.11.16 to >=3.13.2,<4.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Script logic verification: Examine the conditional guards and PATH validation logic in generate_webrtc.sh to ensure the refactored installation flow functions correctly across different environments.
• Dependency constraint impact: Verify that loosening the twirp constraint and tightening aiohttp do not introduce breaking changes or version conflicts.
• Workflow integration: Confirm the removal of twirp in the release workflow aligns with the build script changes and does not break the release process.

Poem

🐰 Dependencies dance in neat array,
Twirp removed for a cleaner way,
Sync consolidated, paths verified right,
Build scripts trimmed in morning light,
Aiohttp strengthened, constraints take flight! 🚀

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix codegeneration flow' directly relates to the main changes in the PR, which involve updates to the code generation workflow in generate_webrtc.sh, release.yml, and pyproject.toml.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch code-gen-fixes

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

pyproject.toml (1)

35-58: Remove duplicate and conflicting dependencies in the webrtc block.

The webrtc optional-dependencies list contains significant duplicates with conflicting constraints:

• Conflicting protobuf versions: Line 43 specifies "protobuf>=4.25.1" while line 55 specifies "protobuf>=6.31.1" — pip will use the last one, silently ignoring the earlier constraint.
• Duplicate numpy: Lines 37 ("numpy>=2.2.6,<2.3") and 48 ("numpy>=2.2.6") with different version ranges.
• Duplicate torch & torchaudio: Lines 38–39 and lines 50–51.
• Duplicate scipy: Lines 41 ("scipy>=1.15.3,<1.16") and 52 ("scipy>=1.15.3").
• Duplicate websockets & websocket-client: Lines 44–45 and 56–57.

This suggests incomplete refactoring or a merge conflict resolution error. Consolidate into a single, clean list with non-conflicting constraints.

Apply this diff to deduplicate and align constraints:

 webrtc = [
     "aiortc-getstream==1.13.0.post1",
     "numpy>=2.2.6,<2.3",
     "torch>=2.7.1",
     "torchaudio>=2.7.1",
     "soundfile>=0.13.1",
     "scipy>=1.15.3,<1.16",
     "twirp",
     "protobuf>=6.31.1",
     "websockets>=15.0.1,<16",
     "websocket-client>=1.8.0",
     "python-dateutil>=2.8.2",
     "structlog<24",
     "tenacity>=9.1.2",
     "aiohttp>=3.13.2,<4",
     "ping3>=4.0.8",
 ]

Note: Resolved to use protobuf>=6.31.1 (the newer constraint) and tightened numpy/scipy/websockets to versions with upper bounds per the first occurrence.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 59b3bc1 and c181062.

⛔ Files ignored due to path filters (1)

• uv.lock is excluded by !**/*.lock

📒 Files selected for processing (3)

• .github/workflows/release.yml (1 hunks)
• generate_webrtc.sh (2 hunks)
• pyproject.toml (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: Tests (3.11)
• GitHub Check: Tests (3.13)
• GitHub Check: Tests (3.10)
• GitHub Check: Tests (3.12)

🔇 Additional comments (4)

generate_webrtc.sh (3)

15-19: -f flag on submodule add ensures idempotency.

Adding the -f flag allows the script to safely re-run if the submodule already exists. LGTM.

---

36-40: Clearer protoc installation instructions.

Updated guidance from referencing a script to standard brew install protoc is more user-friendly and portable. LGTM.

---

42-44: Consolidation of dependency installation is sound.

The single uv sync call with --all-extras --dev --all-packages ensures all dependencies are available for code generation. LGTM.

.github/workflows/release.yml (1)

36-39: Remove the verification request—no resolution risk exists.

The uv remove command on line 38 targets the dev group, but twirp is only declared in the webrtc optional-dependency (no version constraint). The uv.lock file confirms that twirp 0.0.7 resolves successfully from PyPI, not from a git source. This is defensive code to avoid releasing git-based dependencies; it poses no resolution failure risk since the PyPI package already resolves correctly.

Likely an incorrect or invalid review comment.