Fix BufferedMediaTrack.stop()

[dangusev]

Summary by CodeRabbit

• Bug Fixes
  • Improved media track shutdown logic to more reliably stop underlying tracks and reduce cleanup errors.
  • No changes to public APIs or interfaces—behavioral fixes only.

[coderabbitai]

Walkthrough

Modified BufferedMediaTrack.stop to invoke the underlying track's stop() method instead of stop_audio(). Error handling and logging remain unchanged. No public API signatures were altered.

Changes

Cohort / File(s)	Summary
BufferedMediaTrack.stop method getstream/video/rtc/track_util.py	Replaced call to underlying track's stop_audio() with a call to stop() during track cleanup; surrounding error handling unchanged

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify stop() exists on all supported track implementations.
• Confirm no tracks rely solely on a stop_audio() method (add fallback if needed).
• Review tests or runtime paths where track stopping is exercised.

Poem

🐰 I hopped along the media line,
Swapped a call and felt just fine.
Now when tracks end, with one last hop,
stop() takes charge — and then we stop. 🎧

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix BufferedMediaTrack.stop()' directly corresponds to the main change: fixing the stop() method in BufferedMediaTrack by calling the correct underlying track method.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/buffered-track-close

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between fa0263f and 3f02b65.

📒 Files selected for processing (1)

• getstream/video/rtc/track_util.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• getstream/video/rtc/track_util.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}