Skip to content

Conversation

@dangusev
Copy link
Contributor

@dangusev dangusev commented Nov 14, 2025

Summary by CodeRabbit

  • Chores
    • Minor internal maintenance updates to improve system observability.

Note: This release contains internal updates with no changes to user-facing functionality or behavior.

@coderabbitai
Copy link

coderabbitai bot commented Nov 14, 2025

Walkthrough

A log level adjustment in the track publication handler, changing error-level logging to info-level for track publication events in the RTC tracks module. No functional behavior modifications.

Changes

Cohort / File(s) Change Summary
Logging level adjustment
getstream/video/rtc/tracks.py
Modified handle_track_published to log track publication events at info level instead of error level

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single-line log level change with no behavioral impact
  • No logic modifications or conditional restructuring

Poem

🐰 A little log did change its tone,
From error's shout to info's song,
The track published, calm and bright,
No crash nor fright, just info's light! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Reduce log severity' accurately describes the main change: converting error-level logging to info-level logging in the track publication event handler.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/logs-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
getstream/video/rtc/tracks.py (1)

225-225: Consider adjusting other log levels in this function.

While reviewing the changed line, I noticed other logger.error calls in this function that may also warrant review:

  • Line 225: "Not subscribing to track" is a normal policy decision, not an error—consider logger.debug or logger.info
  • Line 237: "Already subscribed" could be logger.debug or logger.info
  • Lines 245-247: "Max subscription limit reached" is an expected condition based on configuration—consider logger.warning or logger.info

Also applies to: 237-237, 245-247

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d56503f and 354b4c5.

📒 Files selected for processing (1)
  • getstream/video/rtc/tracks.py (1 hunks)
🔇 Additional comments (1)
getstream/video/rtc/tracks.py (1)

201-203: LGTM! Log level correction is appropriate.

The change from logger.error to logger.info is correct—handling a track publication is a normal operational event, not an error condition.

@Nash0x7E2 Nash0x7E2 merged commit df29e9b into main Nov 14, 2025
5 checks passed
@dangusev dangusev deleted the chore/logs-cleanup branch November 14, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants