Fix rare netid desync when crafting (#4997)

AJ-Ferguson · web-flow · commit 46b2c0321545 · 2024-08-27T05:37:01.000-04:00
diff --git a/core/src/main/java/org/geysermc/geyser/translator/inventory/PlayerInventoryTranslator.java b/core/src/main/java/org/geysermc/geyser/translator/inventory/PlayerInventoryTranslator.java
@@ -123,7 +123,7 @@ public static void updateCraftingGrid(GeyserSession session, Inventory inventory
             if (session.getGameMode() == GameMode.CREATIVE) {
                 slotPacket.setItem(UNUSUABLE_CRAFTING_SPACE_BLOCK.apply(session.getUpstream().getProtocolVersion()));
             } else {
-                slotPacket.setItem(ItemTranslator.translateToBedrock(session, inventory.getItem(i).getItemStack()));
+                slotPacket.setItem(inventory.getItem(i).getItemData(session));
             }
 
             session.sendUpstreamPacket(slotPacket);

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ public static void updateCraftingGrid(GeyserSession session, Inventory inventory`
`123`	`123`	`if (session.getGameMode() == GameMode.CREATIVE) {`
`124`	`124`	`slotPacket.setItem(UNUSUABLE_CRAFTING_SPACE_BLOCK.apply(session.getUpstream().getProtocolVersion()));`
`125`	`125`	`} else {`
`126`		`- slotPacket.setItem(ItemTranslator.translateToBedrock(session, inventory.getItem(i).getItemStack()));`
	`126`	`+ slotPacket.setItem(inventory.getItem(i).getItemData(session));`
`127`	`127`	`}`
`128`	`128`
`129`	`129`	`session.sendUpstreamPacket(slotPacket);`