Skip to content

Conversation

@weber-s
Copy link
Contributor

@weber-s weber-s commented Jul 23, 2018

A simple "fixing typo" PR.

Thanks for your job 👍

@GibbsConsulting
Copy link
Owner

Thanks for the contribution. However, isn't the documentation correct when it says that the tag is called plotly_app ?

@weber-s
Copy link
Contributor Author

weber-s commented Jul 24, 2018

Oh. Sorry. indeed. It's plotly_item that does not exist. I was confused because the docs in "Simple usage" as well as in "template tag" is the following:

.. code-block:: jinja

  {%load plotly_dash%}
  {%plotly_item name="SimpleExample"%}

Then, this example is wrong.
There is a bunch of example with plotly_item, should it be corrected to plotly_app ?

>>> git grep plotly_item
README.md:{% plotly_item name="SimpleExample" %}
django_plotly_dash/templatetags/plotly_dash.py:@register.inclusion_tag("django_plotly_dash/plotly_item.html", takes_context=True)
docs/installation.rst:The ``plotly_item`` tag in the ``plotly_dash`` tag library can then be used to render any registered dash component. See :ref:`simple_use` for a simple example.
docs/simple_use.rst:  {%plotly_item name="SimpleExample"%}
docs/template_tags.rst:  {%plotly_item name="SimpleExample"%}
docs/template_tags.rst:  {%plotly_item ... DjangoDash instances using live updating ... %}

@GibbsConsulting
Copy link
Owner

Yes, it looks like the documentation didn't get updated when the code was refactored.
Are you in a position to submit an updated pull request? No worries if not.

@weber-s
Copy link
Contributor Author

weber-s commented Jul 25, 2018

Hi!

Here is a commit to fix this issue.

@GibbsConsulting
Copy link
Owner

Merged into prerelease branch v0.5.1. Thanks very much for the contribution.

@GibbsConsulting GibbsConsulting merged commit 7c397c7 into GibbsConsulting:master Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants