Parent div and frame identifiers #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the generation and optional use of class name and unique identifiers for app templates.
This addresses #20
One template tag - plotly_class - is provided to generate a list of names, suitable for use as css names or identifiers, given a django-plotly-dash app and optional prefix and postfix strings.
A second tag - plotly_app_identifier - returns the internal (slug-friendly) name for the app, annotated with an optional postfix string.
The user has to decide how to wield these tools - it is hard to see how the choice between class name and identifier can be automated, and in the case of identifiers how to ensure uniqueness when multiple apps are present.