Skip to content

Add better sourcing of version info #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2018
Merged

Add better sourcing of version info #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2789038
Add better sourcing of version info
Dec 8, 2018
7d8b26c
Improved import of version number into setup.py
Dec 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion django_plotly_dash/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@
SOFTWARE.
'''

__version__ = "0.9.4"
from .version import __version__

from .dash_wrapper import DjangoDash
7 changes: 7 additions & 0 deletions django_plotly_dash/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
'''
Define version number for django-plotly-dash, in a form that can be used by setup.py without importing the package.

This addresses issue #81
'''

__version__ = "0.9.4"
4 changes: 2 additions & 2 deletions docs/development.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ Release builds
This section contains the recipe for building a release of the project.

First, update the version number appropriately
in ``django_plotly_dash/__init__.py``, and then
in ``django_plotly_dash/version.py``, and then
ensure that the checks and tests have been run::

./check_code
Expand All @@ -140,7 +140,7 @@ first a snapshot of the development environment used for the build should be gen
pip freeze > frozen_dev.txt

git add frozen_dev.txt
git add django_plotly_dash/__init__.py
git add django_plotly_dash/version.py

git commit -m" ... suitable commit message for this release ..."

Expand Down
8 changes: 5 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,18 @@

from setuptools import setup

import django_plotly_dash as dpd
#import django_plotly_dash as dpd
#VERSION = dpd.__version__

VERSION = dpd.__version__
with open('django_plotly_dash/version.py') as f:
exec(f.read())

with open('README.md') as f:
long_description = f.read()

setup(
name="django-plotly-dash",
version=VERSION,
version=__version__,
url="https://github.com/GibbsConsulting/django-plotly-dash",
description="Django use of plotly dash apps through template tags",
long_description=long_description,
Expand Down