Globally configured texts are never used

[toncid]

The following chunk makes sure that the scope value is always set:

// default text
scope.todayText = scope.todayText || 'Today';
scope.nowText = scope.nowText || 'Now';
scope.clearText = scope.clearText || 'Clear';
scope.closeText = scope.closeText || 'Close';
scope.dateText = scope.dateText || 'Date';
scope.timeText = scope.timeText || 'Time';

Afterwards, the getText() function never fall back to the global config, i.e. scope[key + 'Text'] is always set:

scope.getText = function (key) {
    return scope[key + 'Text'] || uiDatetimePickerConfig[key + 'Text'];
};

Thoughts?

[Gillardo]

Give me a second, fixing it now for you

On Tue, Jul 7, 2015 at 3:56 PM, Tonči Damjanić notifications@github.com
wrote:

The following chunk makes sure that the scope value is always set:

// default text
scope.todayText = scope.todayText || 'Today';
scope.nowText = scope.nowText || 'Now';
scope.clearText = scope.clearText || 'Clear';
scope.closeText = scope.closeText || 'Close';
scope.dateText = scope.dateText || 'Date';
scope.timeText = scope.timeText || 'Time';

Afterwards, the getText() function never fall back to the global config,
i.e. scope[key + 'Text'] is always set:

scope.getText = function (key) {
return scope[key + 'Text'] || uiDatetimePickerConfig[key + 'Text'];
};

Thoughts?

—
Reply to this email directly or view it on GitHub
#27.

[Gillardo]

Fixed for you. Latest version is 1.1.2. Please close the issue when you have confirmed it is ok.

[toncid]

Looks good! Thanks!