Erasing hours or minutes field of datetime causes angular error and permanent input error.

[ArielAleksandrus]

I'm using version 1.2.3 of this tool and 0.13.4 of angular ui.

To replicate this error, just erase the hours or minutes when prompted to pick a time.

Angular error is: Error: [$rootScope:inprog] http://errors.angularjs.org/1.4.0/$rootScope/inprog?p0=%24apply

[Gillardo]

Have you tried this with the timepicker control from angular-ui only??

What was the error you got?

On Wed, Oct 7, 2015 at 2:36 PM, ArielAleksandrus notifications@github.com
wrote:

I'm using version 1.2.3 of this tool and 0.13.4 of angular ui.

To replicate this error, just erase the hours or minutes when prompted to
pick a time.

—
Reply to this email directly or view it on GitHub
#56.

[ArielAleksandrus]

I already "fixed" it, with some losses. The "solution" I came up to was not that good. Apparently, this is due to:

When we type an invalid time on your plugin, timepicker is closed.

Angular UI Bootstrap 0.13.4, on line 4709, binds an onblur event to minutesInputEl, and there is another one for hoursInputEl. They exist to format the input, I believe. I commented them. This solves the issue of the permanent form error, although it becomes much harder for the user to type a value without the timepicker closing.

I believe that having an aux model for the timepicker that would apply to the datetimepicker when the timepicker was closed would be a nice solution. What do you think?

[Gillardo]

Yeah that could work.

On Wed, Oct 7, 2015 at 2:53 PM, ArielAleksandrus notifications@github.com
wrote:

I already fixed it. Apparently, this is due to:

When we type an invalid time on your plugin, timepicker is closed.

Angular UI Bootstrap 0.13.4, on line 4709, binds an onblur event to
minutesInputEl, and there is another one for hoursInputEl. They exist to
format the input, I believe.

I believe that having an aux model for the timepicker that would apply to
the datetimepicker when the timepicker was closed would be a nice solution.
What do you think?

—
Reply to this email directly or view it on GitHub
#56 (comment)
.

[Gillardo]

I believe this error is now fixed. I thought having a separate model for time would cause issues, due to merging them together and separating them, so i have changed the "clear" option and closing the dropdown when a date is null. This should of only happened when the user was clearing the date, not when the date is invalid because of an invalid input. I have uploaded a new version 1.2.6.

Please try this and let me know if there is anything wrong