fix(instance): clean up exited sessions from catalog after attach #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user exits a session (vs detaching), the multiplexer session is terminated but the catalog entry was left behind. This caused `hjk ps` to show stale sessions that no longer existed. After AttachSession returns, we now check if the session still exists in the multiplexer. If not, we remove it from the catalog. This is best-effort cleanup that won't fail the command if it encounters errors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jmgilman
added a commit
that referenced
this pull request
Jan 3, 2026
Current behavior: When a user exits a session (vs detaching), the multiplexer session is terminated but the catalog entry was left behind. This caused hjk ps to show stale sessions that no longer existed. New behavior: After AttachSession returns, we now check if the session still exists in the multiplexer. If not, we remove it from the catalog. This is best-effort cleanup that won't fail the command if it encounters errors. Closes: #21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
hjk psafter a user exits (vs detaches) from a sessionAttachSessionreturns, checks if the session still exists in the multiplexerProblem
When running
hjk runand then exiting the session (typingexitor process terminates), the session remained in the catalog even though it no longer existed in the multiplexer. This causedhjk ps <branch>to show stale sessions.Solution
Added cleanup logic to
Manager.AttachSession()that runs after the multiplexer attach returns:Test plan
ListSessions🤖 Generated with Claude Code