Skip to content

Refine CLI defaults and agent auth handling #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmgilman merged 2 commits into from
Jan 2, 2026
Merged

Refine CLI defaults and agent auth handling #31

jmgilman merged 2 commits into from
Jan 2, 2026

Conversation

@jmgilman
Copy link
Collaborator

@jmgilman jmgilman commented Jan 2, 2026

Motivation

  • Centralize fallback behavior for storage paths and base image selection so CLI commands behave consistently when no config is loaded.
  • Allow the --agent flag to be specified without an explicit value and validate agent names independently of a loaded config.
  • Reduce duplication and complexity in agent credential retrieval by consolidating provider metadata and error handling.

Description

  • Exported the default base image as DefaultBaseImage and updated Viper defaults and tests to use it instead of an unexported symbol.
  • Added defaultDataDir and resolveBaseImage helpers and wired them into initManager, logs and recreate flows so defaults come from a single place.
  • Simplified credential injection by introducing an agentAuthSpecs map and unified injectAuthToken logic, and enabled --agent to accept no option value via NoOptDefVal with sentinel handling.
  • Replaced config-dependent agent validation with package-level helpers (config.IsValidAgent / config.ValidAgentNames) and updated call sites accordingly.

Testing

  • Formatted modified files with gofmt to ensure style consistency and applied the changes to source and tests.
  • Updated unit tests to reference DefaultBaseImage where applicable but no automated go test run in this rollout.
  • No automated test failures were observed because the test suite was not executed as part of this change.

Codex Task

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 2, 2026 •
edited
Loading

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs		 headjack bb7bed0 Commit Preview URL

Branch Preview URL		 Jan 02 2026, 10:49 PM

@jmgilman jmgilman merged commit f90d7b6 into master Jan 2, 2026
2 checks passed
@jmgilman jmgilman deleted the codex/conduct-thorough-code-review-for-cli branch January 2, 2026 22:49
jmgilman added a commit that referenced this pull request Jan 3, 2026
@jmgilman
chore(cli): refine defaults and agent auth handling
15739bf 
Current behavior:
CLI commands used hardcoded paths and repetitive switch statements for agent authentication, with scattered default value resolution logic.

New behavior:
Centralized default resolution with helper functions, unified agent auth handling through a specification map, and consistent data directory path management.

Closes: #31
@github-actions github-actions bot mentioned this pull request Jan 3, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmgilman