chore: review and clean up CLI code #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses several code quality issues identified during pre-release review: **DRY Refactoring:** - Extract shared container runtime logic into common.go (baseRuntime struct) - Consolidate duplicate gitError helper functions in git.go - Remove redundant Config struct methods (IsValidAgent, ValidAgentNames, etc.) in favor of existing package-level functions **Error Handling Improvements:** - Replace direct error comparisons with errors.Is() throughout: - instance/manager.go: catalog.ErrNotFound checks - keychain/keychain_darwin.go: gokeychain.ErrorItemNotFound checks - Document intentional error skipping in Manager.List **Documentation Improvements:** - Add package documentation to cmd package - Improve GlobalMRUSession struct documentation - Add explanatory comment for sanitizeBranch test **Code Reduction:** - ~250 lines removed through deduplication - container/podman.go and container/apple.go significantly simplified
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
headjack | 8f0288f | Commit Preview URL Branch Preview URL |
Jan 02 2026, 11:05 PM |
jmgilman
added a commit
that referenced
this pull request
Jan 3, 2026
Current behavior: Code contained duplicate runtime logic across container implementations, redundant Config struct methods, direct error comparisons instead of errors.Is(), and missing package documentation New behavior: Shared container logic extracted to baseRuntime struct, duplicate gitError functions consolidated, redundant Config methods removed in favor of package-level functions, error handling improved with errors.Is() throughout codebase, and comprehensive documentation added Closes: #32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several code quality issues identified during pre-release review:
DRY Refactoring:
Error Handling Improvements:
Documentation Improvements:
Code Reduction: